THEME: MoHamdy Portfolio – 1.0.1

[mohamdy]

MoHamdy Portfolio - 1.0.1

Showcase your brilliance with SAQR theme.

Theme URL - ​https://mohamdyweb.com/saqr-theme/
Author URL - ​https://mohamdyweb.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mohamdy-portfolio/1.0.1
WordPress.org - ​https://wordpress.org/themes/mohamdy-portfolio/

SVN - ​https://themes.svn.wordpress.org/mohamdy-portfolio/1.0.1
ZIP - ​https://downloads.wordpress.org/theme/mohamdy-portfolio.1.0.1.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [227743] https://themes.trac.wordpress.org/changeset?old_path=mohamdy-portfolio/1.0&new_path=mohamdy-portfolio/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#174739	THEME: MoHamdy Portfolio – 1.0	closed	not-approved	acosmin
#175081	THEME: MoHamdy Portfolio – 1.0.1	closed	not-approved	acosmin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
• RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
• WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="​https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• WARNING: screenshot.png is 607.8 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
• RECOMMENDED The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.

[acosmin]

@mohamdy

Hi!

I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.

​https://make.wordpress.org/themes/handbook/review/required/

​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

​https://github.com/WPTRT/theme-sniffer/

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

---

1. ​Skip link - not ok

2. ​Keyboard navigation - not ok
   • Some resources to help you:
     • ​Information on the requirement
     • Video help for: ​Modals, ​Links, ​Forms, ​Menus
     • Check TwentyTwenty using tab and shift+tab as an example
   • Issues with your theme:
     • nothing works as it should

3. No Console issues:

   	GET http://.../about/page-markup-and-formatting/assets/img/SAQR.png 404 (Not Found)
   

4. No minification of scripts or files unless you provide original files

5. All theme text strings are to be translatable. ​Read the requirement

6. Provide a ​unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, wp_enqueue_script/style handle names, add_image_size names, wp_script_add_data keys, slugs/ids for new categories created with register_block_pattern_category etc. Theme nav menu locations and sidebar IDs are exceptions.

7. Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: ​Data Validation)

8. everything about the SAQR Options page is not allowed. Move it into a companion plugin that needs to be hosted on wp.org. You can then recommend it.