Make WordPress Themes

Opened 2 months ago

Closed 2 months ago

#174739 closed theme (not-approved)

THEME: MoHamdy Portfolio – 1.0

Reported by: mohamdy's profile mohamdy Owned by: acosmin's profile acosmin
Priority: new theme Keywords: theme-mohamdy-portfolio
Cc: eng.mohamed.hamdy2010@…

Description

MoHamdy Portfolio - 1.0

Showcase your brilliance with SAQR theme.

Theme URL - https://mohamdyweb.com/saqr-theme/
Author URL - https://mohamdyweb.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mohamdy-portfolio/1.0
WordPress.org - https://wordpress.org/themes/mohamdy-portfolio/

SVN - https://themes.svn.wordpress.org/mohamdy-portfolio/1.0
ZIP - https://downloads.wordpress.org/theme/mohamdy-portfolio.1.0.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

History:

Ticket Summary Status Resolution Owner
#174739 THEME: MoHamdy Portfolio – 1.0 closed not-approved acosmin

(this ticket)

#175081 THEME: MoHamdy Portfolio – 1.0.1 closed not-approved acosmin


https://themes.svn.wordpress.org/mohamdy-portfolio/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments '%s (Invalid)'.
    Line  102: $title = sprintf( __( '%s (Invalid)' ), $menu_item->title );
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments '%s (Pending)'.
    Line  106: $title = sprintf( __( '%s (Pending)' ), $menu_item->title );
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'sub item'.
    Line  123: <span class='is-submenu' <?php echo $submenu_text; ?>><?php _e( 'sub item' ); ?></span>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function esc_attr, with the arguments 'Move up'.
    Line  141: esc_attr__( 'Move up' )
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function esc_attr, with the arguments 'Move down'.
    Line  158: esc_attr__( 'Move down' )
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function esc_attr, with the arguments 'Edit menu item'.
    Line  178: esc_attr__( 'Edit menu item' ),
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments 'Edit'.
    Line  180: __( 'Edit' )
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'URL'.
    Line  191: <?php _e( 'URL' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Navigation Label'.
    Line  198: <?php _e( 'Navigation Label' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Title Attribute'.
    Line  204: <?php _e( 'Title Attribute' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Open link in a new tab'.
    Line  211: <?php _e( 'Open link in a new tab' ); ?>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'CSS Classes (optional)'.
    Line  216: <?php _e( 'CSS Classes (optional)' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Link Relationship (XFN)'.
    Line  222: <?php _e( 'Link Relationship (XFN)' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Icon'.
    Line  228: <?php _e( 'Icon' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Description'.
    Line  234: <?php _e( 'Description' ); ?><br />
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'The description will be displayed in the menu if the active theme supports it.'.
    Line 236: <span class='description'><?php _e( 'The description will be displayed in the menu if the active theme supports
    
  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Move'.
    Line  256: <span class='field-move-visual-label' aria-hidden='true'><?php _e( 'Move' ); ?></span>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Up one'.
    Line  257: <button type='button' class='button-link menus-move menus-move-up' data-dir='up'><?php _e( 'Up one' ); ?></button>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'Down one'.
    Line  258: <button type='button' class='button-link menus-move menus-move-down' data-dir='down'><?php _e( 'Down one' ); ?></button>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function _e, with the arguments 'To the top'.
    Line  261: <button type='button' class='button-link menus-move menus-move-top' data-dir='top'><?php _e( 'To the top' ); ?></button>
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments 'Original: %s'.
    Line  269: printf( __( 'Original: %s' ), '<a href='' . esc_url( $menu_item->url ) . ''>' . esc_htm
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments 'Remove'.
    Line  288: __( 'Remove' )
    

}}}

  • WARNING: Found a translation function that is missing a text-domain in the file walkers/top-menu-edit-walker.php. Function , with the arguments 'Cancel'.
    Line  306: __( 'Cancel' )
    

}}}

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: <title> tag was found in the file header.php. Document titles must not be hard coded, use add_theme_support( "title-tag" ) instead.
    Line 8: <title>mohamdy-portfolio</title>
    

Change History (3)

#1 @themetracbot
2 months ago

The following has been generated by Theme Review Action, this is for informational purposes only.

Theme developers: the Meta team is testing a new tool to help you to discover and fix problems that might otherwise delay approval of your theme. Please give feedback on any errors and omissions in the test results here: https://github.com/WordPress/theme-review-action/issues


"/?p=1" contains PHP errors: Fatal error: Uncaught TypeError: call_user_func(): Argument #1 ($callback) must be a valid callback, function "mohamdy-portfolio_comment_callback" not found or invalid function name in wp-includes/class-walker-comment.php:183
Stack trace:
#0 wp-includes/class-wp-walker.php(147): Walker_Comment->start_el(, Object(WP_Comment), 1, Array)
#1 wp-includes/class-walker-comment.php(139): Walker->display_element(Object(WP_Comment), Array, 2, 0, Array,
)
#2 wp-includes/class-wp-walker.php(390): Walker_Comment->display_element(Object(WP_Comment), Array, 2, 0, Array, )
#3 wp-includes/comment-template.php(2390): Walker->paged_walk(Array, 2, 0, 0, Array)
#4 wp-content/themes/mohamdy-portfolio/comments.php(34): wp_list_comments(Array)
#5 wp-includes/comment-template.php(1617): require('w...')
#6 wp-content/themes/mohamdy-portfolio/single.php(37): comments_template()
#7 wp-includes/template-loader.php(106): include('w...')
#8 wp-blog-header.php(19): require_once('w...')
#9 index.php(17): require('w...')
#10 {main}

thrown in wp-includes/class-walker-comment.php on line 183

See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-php-errors

"/?p=1" contains incomplete output. Make sure the page contains valid html.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-have-complete-output

#2 @acosmin
2 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#3 @acosmin
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

@mohamdy check the issues mentioned by theme check and the PHP fatal error. The theme is unusable.

Note: See TracTickets for help on using tickets.