Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to block bindings replacement logic and stop using regex #6744

Conversation

SantosGuillamot
Copy link

@SantosGuillamot SantosGuillamot commented Jun 6, 2024

What?

Revert part of the changes made in this pull request to avoid using regex that can cause potential bugs like this one.

Why?

The idea of that pull request was to simplify the logic and potentially support more attributes in bindings, but it is causing other problems like the mentioned issue. I believe it is safer to revert these changes and do the refactoring once the HTML API supports CSS selectors and provides a way to set inner content.

How?

Just reverting the changes made to the previous implementation, which seemed to be working fine.

Testing Instructions

Follow the testing instructions of WordPress/gutenberg#62347 (comment) and check that the issue is solved.

I also added a unit test to cover the issue.

Trac ticket: https://core.trac.wordpress.org/ticket/61385


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jun 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props santosguillamot, talldanwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jun 6, 2024

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@SantosGuillamot SantosGuillamot changed the title Revert changes to bindings replacement logic Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me, thanks for the quick fix!

@audrasjb
Copy link
Contributor

Committed in https://core.trac.wordpress.org/changeset/58398
Also added @talldan missed props manually using the Core Props tool on Make/Core :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants