Add e2e test to ensure block bindings work well with symbols and numbers #62410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Will it pass without the fix for #62396? 😄 |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 7, 2024
gziolo
reviewed
Jun 7, 2024
| 'contenteditable', | ||
| 'true' | ||
| ); | ||
| await paragraphBlock.fill( '$10.00' ); |
There was a problem hiding this comment.
I was wondering how it gets saved, but it looks like autosave triggers when opening a preview 👍🏻
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add an e2e case to cover use cases like this one, where symbols and numbers couldn't be used at the start of a binding value.
Why?
To ensure we don't break things again in the future.
How?
I just added a e2e test for a paragraph connected to a custom field. I thought about replicating the same for pattern overrides, but I felt I was just replicating the test. Happy to add it if considered necessary.
Testing Instructions
Tests should pass once this code in WordPress is updated.