BlockGap: Add axial gap option to global styles where available #42490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
|
Size Change: +137 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
30 tasks
|
I think this would be great to add. |
Thanks for the reminder @scruffian! I was tweaking a couple of bugs over the past couple of weeks and this WIP slipped off my to do list. I'll give it a rebase this week and let's see if we can get it in. |
andrewserong
force-pushed
the
try/adding-axial-gap-to-global-styles
branch
from
3dbd970
to
0acc9c4
Compare
andrewserong
removed
the
[Status] In Progress
|
I've given this a rebase, and I believe it's ready for review now 🙂 |
glendaviesnz
approved these changes
Aug 15, 2022
|
Thanks @glendaviesnz! I'll merge this in, but 🤞 we can swap over to using the new spacing controls you've merged before too long. |
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the ability to adjust axial (vertical and horizontal) block spacing / gap in global styles for those blocks that opt into it. For blocks that do not, default to a simple
UnitControlfor adjusting a single gap value.Why?
Some blocks already allow control over separate horizontal and vertical gap (notably Social Icons), so let's make it possible to control that in global styles where available.
How?
Conditionally render a
BoxControlcomponent for adjusting axial gap if the block allows it. Otherwise, default to a simpleUnitControl.Note: this PR currently uses the
BoxControlcomponent, but I imagine we'll likely eventually swap it out for the presets-based spacing controls proposed in #42173.Testing Instructions
UnitControlstill works for adjusting spacing.Screenshots or screencast