Make WordPress Core

Opened 5 years ago

Last modified 2 days ago

#47044 assigned defect (bug)

Twenty Nineteen: Add padding for full-aligned text blocks inside of a full-width column block.

Reported by: kjellr's profile kjellr Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch changes-requested
Focuses: Cc:

Description

As noted by @dianeco, after #46999, text-based blocks inside of a full-width columns block now bump up against the edges of the screen:

https://cldup.com/KnBH49tlCQ-3000x3000.png

In the case of media/image blocks, it's likely that users will want these to bump right up against the edge of the page, so we should try adding some padding only to text-based blocks if possible.

Note that this needs to be fixed in both the editor and front-end.

Attachments (4)

47044.diff (3.0 KB) - added by ianbelanger 5 years ago.
Adds padding to all items in column block, except images
47044-before-patch.PNG (638.4 KB) - added by ianbelanger 5 years ago.
47044-after-patch.PNG (641.5 KB) - added by ianbelanger 5 years ago.
SCR-20240702-samy.jpeg (348.4 KB) - added by karmatosed 8 days ago.

Download all attachments as: .zip

Change History (12)

#1 @kjellr
5 years ago

Noting that there's a somewhat related bug in the editor right now:

https://github.com/WordPress/gutenberg/issues/15192

When a column block is set to be fullscreen, The block toolbar for nested blocks is pushed off-screen on the left. Not sure if there is also some block padding that's being pushed off-screen.

@ianbelanger
5 years ago

Adds padding to all items in column block, except images

#2 @ianbelanger
5 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 5.3

#3 @davidbaumwald
5 years ago

  • Milestone changed from 5.3 to Future Release

This ticket hasn't seen any movement this cycle. With 5.3 RC1 approaching, this is being moved to Future Release. If a committer feels strongly about this one being in 5.3 and has the time to see it through, it can be moved back up.

#4 @karmatosed
9 days ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#5 @karmatosed
8 days ago

  • Keywords commit added

Moving this to testing and potential commit.

#6 @karmatosed
8 days ago

  • Keywords changes-requested added; commit removed

Sadly in testing I can see this in the front resolves it but not in the editor. This means we need to have a patch that also fixes in the editor I think using the latest patch.

#7 @sabernhardt
8 days ago

Side note: if you followed the link from commit r58627, that relates to #61186.

#8 @karmatosed
2 days ago

  • Keywords needs-testing removed
  • Owner karmatosed deleted

@sabernhardt yes I resolved that in the other issue, apologies for not looping back here. I am going to. unassign myself as what needs to happen here is the following:

  • Changes to the patch to make sure this works on both front and editor.
  • Testing once the patch has been made.
Note: See TracTickets for help on using tickets.