Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#47043 closed defect (bug) (fixed)

i18n: Merge similar translation strings - database related strings

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots has-patch commit
Focuses: administration Cc:

Description

See the attached screenshots.

Attachments (6)

47043.png​ (61.5 KB) - added by ramiy 5 years ago.
47043a.png​ (49.2 KB) - added by ramiy 5 years ago.
47043b.png​ (41.3 KB) - added by ramiy 5 years ago.
47043c.png​ (38.1 KB) - added by ramiy 5 years ago.
47043.patch​ (2.9 KB) - added by ramiy 5 years ago.
47043.installation.png​ (31.2 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (17)

@ramiy
5 years ago

@ramiy
5 years ago

@ramiy
5 years ago

@ramiy
5 years ago

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Focuses administration added
  • Keywords has-screenshots has-patch added

This ticket was mentioned in ​Slack in #core-php by sergey. ​View the logs.
5 years ago

#3 @ramiy
5 years ago

  • Keywords site-health added

#4 @desrosj
5 years ago

  • Component changed from General to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#5 @ramiy
5 years ago

@SergeyBiryukov @desrosj Can you change the ticket milestone to 5.4 ?

#6 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.4
  • Status changed from assigned to reviewing

This ticket was mentioned in ​Slack in #core-site-health by clorith. ​View the logs.
4 years ago

#8 @Clorith
4 years ago

  • Keywords commit added; site-health removed

Looks good to me, marking for commit so we can get them changed before beta.

This ticket was mentioned in ​Slack in #core by clorith. ​View the logs.
4 years ago

@SergeyBiryukov
4 years ago

#10 @SergeyBiryukov
4 years ago

The changes in class-wp-debug-data.php look good, however I would keep the config setup screen as is:

  • "Username" and "Password" look better there, otherwise there's a lot of "database" repetition, considering also the comments on the right side.
  • I'm not sure the title case of those labels should be changed, as they are capitalized on the next installation screen, see 47043.installation.png​. It looks like we're just changing one inconsistency for another.

#11 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47268:

Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in wp-admin/setup-config.php.

Props ramiy.
Fixes #47043.

Note: See TracTickets for help on using tickets.