Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#83817 closed theme (not-approved)

THEME: Fantom – 1.0.0

Reported by: asrsagar087's profile asrsagar087 Owned by: poena's profile poena
Priority: new theme Keywords: theme-fantom
Cc: sagarray867@…

Change History (2)

#1 @poena
4 years ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Themes Team needs you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/
https://developer.wordpress.org/themes/

Test your theme with these plugins:
https://github.com/WPTRT/theme-sniffer/
https://github.com/WordPress/theme-check


This theme has many of the problems that I have already mentioned to you when I have reviewed your previous themes.

Themes are required to be 100% GPL compatible.
Reviewers can not confirm that a theme is GPL compatible unless all the license information is included in the theme.
This includes third party styles, scripts, fonts and images, even images in the screenshot.

Provide a unique prefix for everything the Theme defines in the public namespace,
including options, functions, global variables, constants, post meta, etc.
Theme nav menu locations and sidebar IDs are exceptions.

No minification of scripts or files unless you provide original files.
Themes can use minified files, but they also need to include the original,
non minified version.

The readme file is invalid.
Contributors need to be your WordPress.org username, nothing else.

All theme text strings are to be translatable.
There is text in the theme that is missing translation functions.
Unfortunately there is no tool or plugin that can help you find these strings.
You will need to look through all of your files manually.

All untrusted data should be escaped before output.
Theme options are not considered safe.
Do not echo get_theme_mod without escaping.
Make sure that the escaping functions are used correctly.
Only use esc_attr inside HTML attributes.
If you want to escape content between html tags, use esc_html.
Escape links and image sources with esc_url().

Read more:
https://developer.wordpress.org/themes/theme-security/
https://developer.wordpress.org/reference/functions/esc_attr/
https://developer.wordpress.org/reference/functions/esc_attr_e/
https://developer.wordpress.org/reference/functions/esc_attr__/

https://developer.wordpress.org/reference/functions/esc_html/
https://developer.wordpress.org/reference/functions/esc_html__/
https://developer.wordpress.org/reference/functions/esc_html_e/

https://developer.wordpress.org/reference/functions/esc_url/

When I try to activate the theme, it is broken, and I see over 100 PHP notices,
I am only going to copy paste some of them below:

    Notice: Trying to get property 'walker' of non-object in /var/www/html/wp-content/themes/fantom/inc/navwalker.php on line 104 
    Notice: Trying to get property 'has_children' of non-object in /var/www/html/wp-content/themes/fantom/inc/navwalker.php on line 104 
    Notice: Trying to get property 'theme_location' of non-object in /var/www/html/wp-content/themes/fantom/functions.php on line 140 
    Notice: Trying to get property 'walker' of non-object in /var/www/html/wp-content/themes/fantom/inc/navwalker.php on line 173 
    Notice: Trying to get property 'has_children' of non-object in /var/www/html/wp-content/themes/fantom/inc/navwalker.php on line 173 
    Notice: Trying to get property 'walker' of non-object in /var/www/html/wp-content/themes/fantom/inc/navwalker.php on line 199 

There are also missing files (404's) and JavaScript errors that must be fixed.


I did not fully understand what you meant to do with theme_style.php,
but this is not the correct way to add apply styles or color settings,
and it is causing a server error.


Note: See TracTickets for help on using tickets.