THEME: Rocks – 1.2.0

[asrsagar087]

Rocks - 1.2.0

One Page Personal Portfolio Wordpress Theme.

Theme URL - ​https://codeshaper.net/projects/rocks
Author URL - ​https://codeshaper.net/

Trac Browser - https://themes.trac.wordpress.org/browser/rocks/1.2.0
WordPress.org - ​https://wordpress.org/themes/rocks/

SVN - ​https://themes.svn.wordpress.org/rocks/1.2.0
ZIP - ​https://wordpress.org/themes/download/rocks.1.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rocks/1.1.0&new_path=rocks/1.2.0

History:

Ticket	Summary	Status	Resolution	Owner
#74287	THEME: Rocks – 1.1.0	closed	not-approved	poena
#74410	THEME: Rocks – 1.2.0	closed	not-approved	Marcio Zebedeu
(this ticket)

Theme Check Results:

• RECOMMENDED: Tags: is either empty or missing in style.css header.

[Marcio Zebedeu]

Hi @asrsagar087

I started reviewing the subject. 
Give me about five days until I post my first review here.

The entire review process will be as described below.

1. I review the theme according to the theme Review manual and place the result here as a comment.
2. You solve all problems.
3. You access ​https://wordpress.org/themes/upload / and upload the new version again.
   • The theme must have the same name
   • You need to change the style version tag.css
   • New version will be attached to this ticket.
   • It is better to record your changes in the document.
4. We go through process number one through three again until we find no more problems.
5. I approve of the subject and this ticket will have an approved status .
6. One of the administrators will check this theme and review the theme for himself and do it live. It is possible that the administrative reviewer will add more problems.

[kafleg]

Assigned to @marcio-zebedeu

@asrsagar087 Is your theme accessibility-ready? Or you unknowingly added that tag?

[asrsagar087]

Replying to kafleg:

Assigned to @marcio-zebedeu

Yes the theme accessibility is ready. If you need access I will send you it.

[asrsagar087]

Replying to Marcio Zebedeu:
Thanks for your valuable message. Hopefully, I will fix the all issues as soon as possible I can.

[Marcio Zebedeu]

I am closing this ticket because theme has lots of issues.

When the theme has more than 3 issues, the reviewer can close. If ticket is closed with such 3+ issues, then your new theme update would have to go through review queue again to get another round of review.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. The Theme Review Team needs you to read the requirements more carefully. Also, test your theme with following plugins.

Always use the Sniffer theme plugin to analyze your theme as it ensures your theme adheres to the WordPress encoding conventions. ​https://github.com/WPTRT/theme-sniffer/

If the requirements are unclear, let us know so that we can continue to improve them.
​https://make.wordpress.org/themes/handbook/review/required/
​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

After that, validate your readme.txt file to see if it's all right:
​https://wordpress.org/plugins/developers/readme-validator/

Please use the Theme Unit Test data to test your theme.
​https://github.com/WPTRT/theme-unit-test

---

Your theme does not specify the php version in the readme.txt file. The required PHP version is used by the theme directory, so that needs to be included.

​https://make.wordpress.org/themes/handbook/review/required/#example

---

The version of your theme in the readme.txt file does not match the version that is in the style.css file

---

The theme url is optional and if used, it should be about the theme we are hosting in WordPress.org : ​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links and ​https://make.wordpress.org/themes/handbook/review/required/#examples-6
Until the time I reviewed this theme the link of the author of the theme was unavailable. This link should be about theme

---

Your theme must be 100% GPL which means you must declare the licenses of all included features, such as sources or images, js, css of third parties : ​https://make.wordpress.org/themes/handbook/review/required/#licensing

---

I detected an embedded encoding of script and style files on your theme. That's wrong. There is no encoding of script and style files. 
The script on footer.php and header needs to be queued. Use wp_add_inline_script. Link will help ​https://developer.wordpress.org/reference/functions/wp_add_inline_script/

Check here how to do: ​https://make.wordpress.org/themes/handbook/review/required/#examples-7 and ​https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

in rocks/template-parts/footer/wrapper-footer.php and header

---

They are not allowed to import content to a user's site : ​https://make.wordpress.org/themes/handbook/review/required/#importing-or-downloading and ​https://make.wordpress.org/themes/handbook/review/required/#examples-4

---

The theme must respect the users settings. Themes cannot change any options without the users knowledge.

<?php

function rocks_after_import_setup() {
    // Assign menus to their locations.
    $main_menu = get_term_by( 'name', 'Main Menu', 'nav_menu' );

    set_theme_mod( 'nav_menu_locations', array(
            'main-menu' => $main_menu->term_id,
        )
    );

    // Assign front page and posts page (blog page).
    $front_page_id = get_page_by_title( 'Home' );
    $blog_page_id  = get_page_by_title( 'Blog' );

    update_option( 'show_on_front', 'page' );
    update_option( 'page_on_front', $front_page_id->ID );
    update_option( 'page_for_posts', $blog_page_id->ID );
}
add_action( 'pt-ocdi/after_import', 'rocks_after_import_setup' );

---

Your functions are not specified correctly, but only a single prefix. It is not ideal to have a prefix such as : " yourprefix" as it was found in your file meta_functions.php : ​https://make.wordpress.org/themes/handbook/review/required/#code and ​https://themereview.co/prefix-all-the-things/

---

In its archive.php you used the wp_query class but did not use it. I don't know what you wanted to do, but you need to remove it because you're not using it.

---

Your Rocks Custom Post plugin is not available on the link you provided. Please fix it.

---

Your theme has disnecessary files that are not being used such as assts/inc/send.php should be removed

---

Remove the closing tag ?> in rocks/includes/backend/mj-wp-breadcrumb.php and other archives

---

Use prefix for your theme functions and variables especially global variables.
global variable found: $theme_option

---

Code for favicon found. Favicons are handled by the "Site Icon" setting in the customizer since WP version 4.3. : rocks/template-parts/metatag/meta-tag.php

---

The color of the header text is not working for me. I can't make a change.

---

Theme options are not considered safe. Do not echo get_theme_mod without escaping.

---

Add wp_body_open hook on header.php right after <body <?php body_class(); ?>>

<?php

if ( function_exists( 'wp_body_open' ) ) {
                            wp_body_open();
                }

---

Note : Escapes all output after the echo.

Make sure that the escaping functions are used correctly.

​https://developer.wordpress.org/reference/functions/esc_attr/
​https://developer.wordpress.org/reference/functions/esc_attr_e/
​https://developer.wordpress.org/reference/functions/esc_attr__/

​https://developer.wordpress.org/reference/functions/esc_html/
​https://developer.wordpress.org/reference/functions/esc_html__/
​https://developer.wordpress.org/reference/functions/esc_html_e/

​https://developer.wordpress.org/reference/functions/esc_url/

example: Escape get_permalink() with esc_url().
Escape home_url() with esc_url().

---