Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

#73605 closed theme (not-approved)

THEME: Begro – 1.0.2

Reported by: midexigner's profile midexigner Owned by: poena's profile poena
Priority: new theme Keywords: theme-begro accessibility-ready
Cc: midexigner@…

Description

Begro - 1.0.1

Begro is an elegant, versatile theme that gives you the tools you need to express who you are and what your business does in a professional and coherent manner. To help you get started with your website we’ve made sure to include 4 homepage layouts, 10 unique heros, and some 50+ content blocks that you can use to tailor MID to your needs and preferences.

Theme URL - https://www.midexigner.com/devs/begro
Author URL - https://www.midexigner.com

Trac Browser - https://themes.trac.wordpress.org/browser/begro/1.0.1
WordPress.org - https://wordpress.org/themes/begro/

SVN - https://themes.svn.wordpress.org/begro/1.0.1
ZIP - https://wordpress.org/themes/download/begro.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#73605 THEME: Begro – 1.0.2 closed not-approved poena

(this ticket)

#83076 THEME: Begro – 1.0.3 closed not-approved poena
#83261 THEME: Begro – 1.0.5 closed not-approved poena
#83762 THEME: Begro – 1.0.6 closed not-approved acosmin


https://themes.svn.wordpress.org/begro/1.0.1/screenshot.png

Change History (3)

#1 @themetracbot
5 years ago

  • Keywords changed from theme-begro, accessibility-ready to theme-begro accessibility-ready
  • Summary changed from THEME: Begro – 1.0.1 to THEME: Begro – 1.0.2

Begro - 1.0.2

Begro is an elegant, versatile theme that gives you the tools you need to express who you are and what your business does in a professional and coherent manner. To help you get started with your website we’ve made sure to include 4 homepage layouts, 10 unique heros, and some 50+ content blocks that you can use to tailor MID to your needs and preferences.

Theme URL - https://www.midexigner.com/devs/begro
Author URL - https://www.midexigner.com

Trac Browser - https://themes.trac.wordpress.org/browser/begro/1.0.2
WordPress.org - https://wordpress.org/themes/begro/

SVN - https://themes.svn.wordpress.org/begro/1.0.2
ZIP - https://wordpress.org/themes/download/begro.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=begro/1.0.1&new_path=begro/1.0.2

History:

Ticket Summary Status Resolution Owner
#73605 THEME: Begro – 1.0.2 closed not-approved poena

(this ticket)

#83076 THEME: Begro – 1.0.3 closed not-approved poena
#83261 THEME: Begro – 1.0.5 closed not-approved poena
#83762 THEME: Begro – 1.0.6 closed not-approved acosmin


https://themes.svn.wordpress.org/begro/1.0.2/screenshot.png

#2 @poena
5 years ago

  • Owner set to poena
  • Status changed from new to reviewing

#3 @poena
5 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme,
but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it looses it's position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/
https://github.com/WPTRT/theme-sniffer/

Use this upload form to submit your update: https://wordpress.org/themes/upload/


Themes are required to be 100% GPL compatible.
Reviewers can not confirm that a theme is GPL compatible unless all the license information is included in the theme.
-Greensock is not compatible with GPL. Always make sure that you read the licenses carefully.
-It is not enough to include the name of the asset.
-There are also assets that are not included in the list you have added to the readme file.

Why is the description in the readme copied from the default theme?
Why does the tgmpa file say it is for a theme called Serenity lite?
* @version 2.6.1 for parent theme Serenity Lite for publication on WordPress.org
Themes cannot include parts of other themes without providing attribution
by including their license and copyright information.

The theme includes hard coded text content that is not suitable for WordPress.org,
the user cannot be expected to edit the PHP files directly to changes things like menus.

No minification of scripts or files unless you provide original files.
Themes can use minified files, but they also need to include the original, non minified version.

Notices has to use the core style, and must be dismissable. The notice you are using can only be closed, and shows again if a page is reloaded.

Provide a unique prefix for everything the Theme defines in the public namespace,
including options, functions, global variables, constants, post meta, etc.
Theme nav menu locations and sidebar IDs are exceptions.
Function names like customerOption, itemprop and so on, are not unique enough.
The recommended prefix is the theme slug. "mi" will be too short to be unique.

Themes are required to use existing functionality when it is available,
this includes using the WordPress custom logo functionality, instead of adding your own option.
Themes are not allowed to include a default logo (or favicon).

Validate and/or sanitize untrusted data before entering into the database.
Use a sanitizing function suitable for your type of content, not htmlspecialchars.
Read more:
https://github.com/WPTRT/code-examples/blob/master/customizer/sanitization-callbacks.php

https://developer.wordpress.org/themes/theme-security/

All theme text strings are to be translatable.
There is text in the theme that is missing translation functions.
Unfortunately there is no tool or plugin that can help you find these strings.
You will need to look through all of your files manually.

If the maintainance.php file is meant to be a page or post template, it needs to include the correct file header.
Please refer to https://developer.wordpress.org/themes/

Note: See TracTickets for help on using tickets.