THEME: Rakstal – 1.0.3

[mchevestrier]

Rakstal - 1.0.3

A light and customizable theme made for personal branding websites

Theme URL -
Author URL - ​https://martinchevestrier.000webhostapp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/rakstal/1.0.3

SVN - ​https://themes.svn.wordpress.org/rakstal/1.0.3
ZIP - ​https://wordpress.org/themes/download/rakstal.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rakstal/1.0.2&new_path=rakstal/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#64642	THEME: Rakstal – 1.0.2	closed	closed-newer-version-uploaded	Marcio Zebedeu
#69154	THEME: Rakstal – 1.0.3	closed	not-approved	poena
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: Theme URI: is missing from your style.css header.

[poena]

Hi
I have done a partial review only.

In archive.php:
line 34, do not use the_title() inside an HTML attribute: it is not escaped.
Instead, use the_title_attribute() which is already escaped for usage inside the attributes.
-Also see home.php line 126 and index.php. Search the entire theme for all title attributes and fix them all.

In functions.php:
Remove the duplicate registration of the nav menus,
see lines 23 and 119.

Correct the name of the script and style handles, since this is not a unique prefix.
Line 92, 93, 104
(Do not prefix third party scripts, just your own and the font.)

In home.php:
Links needs to be escaped with esc_url, not esc_attr.
And just like with the title attribute, this problem is in more than one file.
You have to search the entire theme and make sure the problem is fixed.
For example, See index.php.

---

Questions
I did not understand why there are so many style tags in customizer.php.
Would not one be enough?

[poena]

Closing due to inactivity.