THEME: Memak – 1.0.2

[immeet94]

Memak - 1.0.0

Memak is a super minimal theme, both front end and back end. adding no bloat whatesover. It only uses the minimum requirements that WordPress has, a stylesheet, screenshot and the index page.

Theme URL - ​https://github.com/mrmakadia94/memak
Author URL - ​https://profiles.wordpress.org/immeet94/

Trac Browser - https://themes.trac.wordpress.org/browser/memak/1.0.0

SVN - ​https://themes.svn.wordpress.org/memak/1.0.0
ZIP - ​https://wordpress.org/themes/download/memak.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#67333	THEME: Memak – 1.0.2	closed	closed-newer-version-uploaded	chinteshprajapati
(this ticket)
#69821	THEME: Memak – 1.0.4	closed	live	rabmalin

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
• RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[themetracbot]

Memak - 1.0.1

Memak is a super minimal theme, both front end and back end. adding no bloat whatesover. It only uses the minimum requirements that WordPress has, a stylesheet, screenshot and the index page.

Theme URL - ​https://github.com/mrmakadia94/memak
Author URL - ​https://profiles.wordpress.org/immeet94/

Trac Browser - https://themes.trac.wordpress.org/browser/memak/1.0.1

SVN - ​https://themes.svn.wordpress.org/memak/1.0.1
ZIP - ​https://wordpress.org/themes/download/memak.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=memak/1.0.0&new_path=memak/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#67333	THEME: Memak – 1.0.2	closed	closed-newer-version-uploaded	chinteshprajapati
(this ticket)
#69821	THEME: Memak – 1.0.4	closed	live	rabmalin

Theme Check Results:

• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[chinteshprajapati]

Hi,

I am starting to review this theme.

Thanks.

[poena]

Hi @chinteshprajapati Do you plan to continue the review and post your result soon?

[chinteshprajapati]

Replying to poena:

Hi @poena Thanks for assigning a theme.

I have started to review this theme and I will post result soon.

Thanks.

[chinteshprajapati]

Hi @immeet94,

It is a very nice theme. It does require some more work to get it into a usable state.

I found a few things that will require fixing before the theme can be approved. Please make changes and resubmit your theme.

Required

Security
========

1. All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'date'. (footer.php line number 9).

Screenshot
==========

2. Screenshots are allowed to display only dummy text that doesn’t suggest/describe theme features, functionality, or statistics. If it looks like an AD, then it’s not allowed.

Readme
======

3. "modefied" spell mistake on line number 22 readme.txt
4. Please add a real version of the theme in Changelog section like 1.0.1 currently 1.0

Suggestion

5. Please reduce line hight on <p> tag (On front page)
6. Please reduce the margin on heading tag <h1> (On front page)

Thanks.

[themetracbot]

Memak - 1.0.2

Memak is a minimal theme, both front end and back end.

Theme URL - ​https://github.com/mrmakadia94/memak
Author URL - ​https://profiles.wordpress.org/immeet94/

Trac Browser - https://themes.trac.wordpress.org/browser/memak/1.0.2

SVN - ​https://themes.svn.wordpress.org/memak/1.0.2
ZIP - ​https://wordpress.org/themes/download/memak.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=memak/1.0.1&new_path=memak/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#67333	THEME: Memak – 1.0.2	closed	closed-newer-version-uploaded	chinteshprajapati
(this ticket)
#69821	THEME: Memak – 1.0.4	closed	live	rabmalin

Theme Check Results:

• RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

[immeet94]

hi @chinteshprajapati

i just update theme and no need to update the screenshot because it's already dummy text.

please review updated theme.

Thanks.

[chinteshprajapati]

Memak is looking good. All my comments have been addressed nicely. I will see about getting this moved to the queue for double-checking reviews.

[greenshady]

A few notes:

Comments on pages

You must call comments_template() for pages too.

Comments form

You have the comments_form() output inside of the comments list <ol>. That results in broken HTML.

Footer text

Your footer text reads "2019 Memak by Meet Makadia". This implies that you own the Web site the theme is being used on. If adding your theme and/or company name to the footer, it must be clear that you created the theme/design and are not the owner of the site.

Wrong escaping function

The second call to esc_attr() here (from header.php) is used outside of an attribute. It should either be esc_html() or you should simply use bloginfo() instead of get_bloginfo().

<h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><?php echo esc_attr( get_bloginfo( 'name' ) ); ?>

Registering nav menus

When registering nav menu locations in functions.php, it should happen within a callback on a hook. I prefer init but others often use after_setup_theme.

Adding theme support

The following add_theme_support() calls from functions.php should be within the theme setup function hooked to after_setup_theme.

add_theme_support( 'automatic-feed-links' );

add_theme_support( "custom-header");

add_theme_support( "custom-background");

add_theme_support( "post-thumbnails" );

Actually support theme-supported things

When calling add_theme_support(), you must actually add theme support for those features within the theme.

Stylesheet URI

Use get_stylesheet_uri() instead of get_template_directory_uri() . '/style.css':

wp_enqueue_style( 'memak-style', get_template_directory_uri() . '/style.css', '10000', 'all' );

Function calls at end of functions.php

You need to remove these two function calls from the end of the functions.php file:

the_post_thumbnail();

add_editor_style();

[immeet94]

Hello @greenshady and @chinteshprajapati

i just update theme based on provided changes.

please review updated theme.

Thanks.