THEME: Notation – 1.0.5

[MohsenMoridi]

Notation - 1.0.1

Notation is a simple and lightweight free WordPress theme suitable for blogging and it’s responsive to display on mobile.

Theme URL - ​http://mohsenm.com/wordpress-theme/notation/
Author URL - ​http://mohsenm.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notation/1.0.1

SVN - ​https://themes.svn.wordpress.org/notation/1.0.1
ZIP - ​https://wordpress.org/themes/download/notation.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notation/1.0.0&new_path=notation/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#57409	THEME: Notation – 1.0.0	closed	not-approved	poena
#57652	THEME: Notation – 1.0.5	closed	closed-newer-version-uploaded	thememason
(this ticket)
#62072	THEME: Notation – 1.0.7	closed	closed-newer-version-uploaded	thememason
#63418	THEME: Notation – 1.0.8	closed	not-approved	rabmalin
#71794	THEME: Notation – 1.1.01	closed	not-approved	ponvendhan
#75600	THEME: Notation – 1.1.02	closed	not-approved	franchidesign
#136515	THEME: Notation Blog – 1.0	closed	live	acosmin
#143288	THEME: Notation Blog – 1.1	closed	live	themetracbot
#163813	THEME: Notation Blog – 1.2	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

[trtmessenger]

This is a batch message from the Theme Review Team (team leads), please don’t reply to this message.

We just want to let you know that we have a ​program for Trusted Authors and we would like to invite you to read the ​TA requirements and participate.

---

Before you do so, please make sure:

• your theme follows ​all our requirements (check each item in that list and see if it applies to your theme).
• make fewer mistakes.
• you have at least two themes in the directory or one live theme and one in the queue.

---

Some of the advantages of being a Trusted Author:

• as a TA you can submit 1 theme a week, normal authors can submit a theme once every 30 days.
• no review and waiting time, theme goes live in the same day you submit it.

---

Thank you!

[MohsenMoridi]

Why i don't get a review :-( ? it's two week

[trtmessenger]

This is a batch message.

Hi! We have ​new screenshot requirements, please apply them and make sure your theme doesn’t go live with a faulty screenshot (risking getting your theme suspended).

---

Screenshots are allowed to display only dummy text that doesn’t suggest/describe theme features, functionality, or statistics. If it looks like an AD, then it’s not allowed. Dummy text examples:

• Lorem ipsum (or similar generators)
• Text that doesn’t describe your theme, company, service, or products.

---

​Some nice examples to follow

---

Thank you!

[themetracbot]

Notation - 1.0.2

Notation is a simple and lightweight free WordPress theme suitable for blogging and it’s responsive to display on mobile.

Theme URL - ​http://mohsenm.com/wordpress-theme/notation/
Author URL - ​http://mohsenm.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notation/1.0.2

SVN - ​https://themes.svn.wordpress.org/notation/1.0.2
ZIP - ​https://wordpress.org/themes/download/notation.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notation/1.0.1&new_path=notation/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#57409	THEME: Notation – 1.0.0	closed	not-approved	poena
#57652	THEME: Notation – 1.0.5	closed	closed-newer-version-uploaded	thememason
(this ticket)
#62072	THEME: Notation – 1.0.7	closed	closed-newer-version-uploaded	thememason
#63418	THEME: Notation – 1.0.8	closed	not-approved	rabmalin
#71794	THEME: Notation – 1.1.01	closed	not-approved	ponvendhan
#75600	THEME: Notation – 1.1.02	closed	not-approved	franchidesign
#136515	THEME: Notation Blog – 1.0	closed	live	acosmin
#143288	THEME: Notation Blog – 1.1	closed	live	themetracbot
#163813	THEME: Notation Blog – 1.2	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

[wpcoderguy]

Hi @MohsenMoridi

I have reviewed your theme and found following issues:
Required:-

1. No language folder found. all theme text strings should be translatable.

2. Remove unused comment code from header.php

3. No Option for logo in theme customizer

4. No archive.php 404.php page found.

NOTE: Please read ​https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.
Please address those issues and upload new version.

Thanks
wpcoderguy

[MohsenMoridi]

Hello
Thank you very much for taking the time and review Notation theme.
I'll fix the problems and resubmit.
Thanks

[MohsenMoridi]

a question
does my theme need to have the option to upload a logo?

[themetracbot]

Notation - 1.0.3

Notation is a simple and lightweight free WordPress theme suitable for blogging and it’s responsive to display on mobile.

Theme URL - ​http://mohsenm.com/wordpress-theme/notation/
Author URL - ​http://mohsenm.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notation/1.0.3

SVN - ​https://themes.svn.wordpress.org/notation/1.0.3
ZIP - ​https://wordpress.org/themes/download/notation.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notation/1.0.2&new_path=notation/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#57409	THEME: Notation – 1.0.0	closed	not-approved	poena
#57652	THEME: Notation – 1.0.5	closed	closed-newer-version-uploaded	thememason
(this ticket)
#62072	THEME: Notation – 1.0.7	closed	closed-newer-version-uploaded	thememason
#63418	THEME: Notation – 1.0.8	closed	not-approved	rabmalin
#71794	THEME: Notation – 1.1.01	closed	not-approved	ponvendhan
#75600	THEME: Notation – 1.1.02	closed	not-approved	franchidesign
#136515	THEME: Notation Blog – 1.0	closed	live	acosmin
#143288	THEME: Notation Blog – 1.1	closed	live	themetracbot
#163813	THEME: Notation Blog – 1.2	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

[rabmalin]

@wpcoderguy Have you checked the latest update?

[wpcoderguy]

Hello @rabmalin

I am working on it. give you update soon.

Thanks
Wpcoderguy

[wpcoderguy]

Hello @MohsenMoridi @rabmalin

I am working on it. give you update soon.

Thanks
Wpcoderguy

[wpcoderguy]

Hi @
I have reviewed your theme and found following issues:
Required:-

1. No Option for logo option found in theme customizer.

2. remove unsued code or commented code from css line number 935, line number 777.

3. add theme support for add_theme_support( "custom-background", $args )

4. add theme suppport for add_editor_style().

5. fixed follwoing escaping function and datavalidation error.

notation/404.php
6	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
7	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
10	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
notation/archive.php
13	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
13	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
15	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
15	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
17	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
17	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
19	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
19	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
19	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_author_posts_url'
21	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
28	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
28	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
83	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
87	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
notation/comments.php
14	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '_x'
18	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '_nx'
25	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'number_format_i18n'
50	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
notation/footer.php
11	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
20	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
29	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
38	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
47	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
56	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
66	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
76	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
85	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
notation/functions.php
123	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
124	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
129	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
134	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
141	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
147	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
152	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
156	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
160	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
166	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
167	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$accent_color'
notation/header.php
35	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_custom_header'
35	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_custom_header'
45	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_header_textcolor'
47	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_header_textcolor'
59	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
71	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
81	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
91	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
101	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
111	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
121	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
131	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
141	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_theme_mod'
notation/index.php
14	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '__'
14	WARNING	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
69	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
73	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
notation/searchform.php
4	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$unique_id'
5	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '_x'
7	WARNING	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$unique_id'
notation/single.php
8	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
12	WARNING	Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
Thank you for creating with WordPress. Version 4.9.8

NOTE: Please read ​https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.
Please address those issues and upload new version.

Thanks
wpcoderguy

[themetracbot]

Notation - 1.0.4

Notation is a simple and lightweight free WordPress theme suitable for blogging and it’s responsive to display on mobile.

Theme URL - ​http://mohsenm.com/wordpress-theme/notation/
Author URL - ​http://mohsenm.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notation/1.0.4

SVN - ​https://themes.svn.wordpress.org/notation/1.0.4
ZIP - ​https://wordpress.org/themes/download/notation.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notation/1.0.3&new_path=notation/1.0.4

History:

Ticket	Summary	Status	Resolution	Owner
#57409	THEME: Notation – 1.0.0	closed	not-approved	poena
#57652	THEME: Notation – 1.0.5	closed	closed-newer-version-uploaded	thememason
(this ticket)
#62072	THEME: Notation – 1.0.7	closed	closed-newer-version-uploaded	thememason
#63418	THEME: Notation – 1.0.8	closed	not-approved	rabmalin
#71794	THEME: Notation – 1.1.01	closed	not-approved	ponvendhan
#75600	THEME: Notation – 1.1.02	closed	not-approved	franchidesign
#136515	THEME: Notation Blog – 1.0	closed	live	acosmin
#143288	THEME: Notation Blog – 1.1	closed	live	themetracbot
#163813	THEME: Notation Blog – 1.2	closed	live	themetracbot

[MohsenMoridi]

Hello @wpcoderguy

Thank you very much for taking the time and review Notation.
The previous version of Notation had some issues. I tried to fix all the problem that you mentioned.
I hope this new version being approve.
Waiting for your feedback.

Thanks
Mohsen Moridi

[wpcoderguy]

Hi @MohsenMoridi
I have reviewed your theme and found following issues:
Required:-

archive.php
L19, L41, L46 Esc all strings instead of () }} use {{{ esc_attr() in archive.php

Index.php
L28, L33, L49 Esc all strings instead of () }} use {{{ esc_attr()

single.php
L25, L34, 38 Esc all strings instead of () }} use {{{ esc_attr()

Language
All theme text strings are to be translatable.
See Single.php L34, L38

Footer.php
L73 Do not hardcode website url please fix it.

NOTE: Please read

​https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.Please address those issues and upload new version.

Thanks
wpcoderguy

[themetracbot]

Notation - 1.0.5

Notation is a simple and lightweight free WordPress theme suitable for blogging and it’s responsive to display on mobile.

Theme URL - ​http://mohsenm.com/wordpress-theme/notation/
Author URL - ​http://mohsenm.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notation/1.0.5

SVN - ​https://themes.svn.wordpress.org/notation/1.0.5
ZIP - ​https://wordpress.org/themes/download/notation.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notation/1.0.4&new_path=notation/1.0.5

History:

Ticket	Summary	Status	Resolution	Owner
#57409	THEME: Notation – 1.0.0	closed	not-approved	poena
#57652	THEME: Notation – 1.0.5	closed	closed-newer-version-uploaded	thememason
(this ticket)
#62072	THEME: Notation – 1.0.7	closed	closed-newer-version-uploaded	thememason
#63418	THEME: Notation – 1.0.8	closed	not-approved	rabmalin
#71794	THEME: Notation – 1.1.01	closed	not-approved	ponvendhan
#75600	THEME: Notation – 1.1.02	closed	not-approved	franchidesign
#136515	THEME: Notation Blog – 1.0	closed	live	acosmin
#143288	THEME: Notation Blog – 1.1	closed	live	themetracbot
#163813	THEME: Notation Blog – 1.2	closed	live	themetracbot

[wpcoderguy]

Hello @MohsenMoridi,

I did not see any update and reply from your side if you do not fix above mention issue and not update theme with in 1-2 days. I will close this ticket.

NOTE: Please read
​https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.Please address those issues and upload new version.

Thanks
wpcoderguy

[MohsenMoridi]

Hi
I have fixed all the problems you mentioned, it's in version 1.0.5 already. Please check that you have seen this version. If there is a problem, let me know again. I have waited a lot for publish this theme. I've always responded quickly and uploaded the revised version. But it takes a long time for you to respond, and you say just a part of the bug every time. Thank you for your final review.
Please check las version and tell me.

Best regards
Mohsen

[wpcoderguy]

Hi @MohsenMoridi
I have reviewed your theme and found following issues:
Required:-

1.Function.php
L15 No mini version of jquery required in the theme fixed it.

2.Footer.php
L73 Do not hardcode website url please fix it. make user able to change footer copyright url.

3.customizer.php
Porperly use sanitization and esc_html fuction in customizer

4.screenshot.jpg size should be 1200X900

Your Website have more then 3+ distinct issue So I am going to close this ticket and please recheck and resubmit theme.

NOTE: Please read
​https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.Please address those issues and upload new version.

Thanks
wpcoderguy

[thememason]

Asking that an admin reopen this ticket. This feedback is incorrect:

1.Function.php
L15 No mini version of jquery required in the theme fixed it. use built-in scripts wp_enqueue_script('jquery') instead
2.Footer.php
L73 Do not hardcode website url please fix it. make user able to change footer copyright url. This is perfectly fine and not against the rules
3.customizer.php
Porperly use sanitization and esc_html fuction in customizer customizer.php does not exist in the theme files
4.screenshot.jpg size should be 1200X900 Handbook specifies maximum size. Exact size of 1200x900 is not required but should maintain a 4:3 aspect ratio

@acosmin

[thememason]

Hi @MohsenMoridi,

I'll be picking up your theme for review. Here are some issues I found so far:

Requirements:

• You must enqueue jQuery through WordPress core, not an external URL.
• Main menu is not displaying properly when "Headr Menu" is not set

• Image inside text widget is not contained properly (see monster widget plugin for testing)

Please fix these issues and reupload a new version of your theme.

[MohsenMoridi]

Hello @thememason
Thank you for your time، This is very valuable to me.
I will correct the bugs you reported and upload the new version again.
Thank you

[MohsenMoridi]

Hi @thememason
I fixed the issues that you reported and re-upload the (version 1.0.6).

+ Fixed: You must enqueue jQuery through WordPress core, not an external URL.
+ Fixed: Main menu is not displaying properly when "Headr Menu" is not set
+ Fixed: Image inside text widget is not contained properly (see monster widget plugin for testing)
+ Fixed: Handbook specifies maximum size. Exact size of 1200x900 is not required but should maintain a 4:3 aspect ratio

but it drives me to another ticket ( https://themes.trac.wordpress.org/ticket/62072 )
What should I do?

Thank you