Make WordPress Themes

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#49694 closed theme (not-approved)

THEME: OnePage Lite – 1.0.4

Reported by: mythemeshop's profile MyThemeShop Owned by: wpcoderguy's profile wpcoderguy
Priority: new theme Keywords: theme-onepage-lite
Cc: otto@…

Description

OnePage Lite - 1.0.4

OnePage lite is a beautiful single page WordPress theme that has an elegantly designed homepage layout with multiple sections like: Counter, Services, Features, Testimonials and many more. It’s fully responsive and highly optimized for SEO. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=OnePage%20Lite

Theme URL - https://mythemeshop.com/themes/onepage-lite/
Author URL - https://mythemeshop.com/

Trac Browser - https://themes.trac.wordpress.org/browser/onepage-lite/1.0.4

SVN - https://themes.svn.wordpress.org/onepage-lite/1.0.4
ZIP - https://wordpress.org/themes/download/onepage-lite.1.0.4.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#49694 THEME: OnePage Lite – 1.0.4 closed not-approved wpcoderguy

(this ticket)

#52340 THEME: OnePage Lite – 1.0.7 closed not-approved cbaldelomar


https://themes.svn.wordpress.org/onepage-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (6)

#1 @Otto42
7 years ago

  • Reporter changed from Otto42 to MyThemeShop

Manual upload for theme that has 100+ installs already. This theme is created by MyThemeShop and the existing install count was manually checked to ensure that no name collision exists.

Please review as normal and ignore any install count warnings from subsequent uploads of the theme in the process.

This ticket was mentioned in Slack in #themereview by otto42. View the logs.


7 years ago

#3 @themetracbot
6 years ago

  • Owner set to wpcoderguy
  • Status changed from new to reviewing

#4 @wpcoderguy
6 years ago

Hello @MyThemeShop,

I am reviewing theme. Give you update soon.

Thanks

#5 @wpcoderguy
6 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @MyThemeShop

I have reviewed your theme and found following issues:

Required:-

  1. TGM Not working getting following message

Installation failed: An unexpected error occurred. Something may be wrong with WordPress.org or this
server’s configuration. If you continue to have problems, please try the support forums.
Something went wrong with the plugin API.

  1. Please remove minified version from you theme under css directory font-awesome.min

function.php line number 266

  1. In archive.php Line Number 43 scaping function used like esc_html_e() or esc_attr_e() not '_e'

onepage-lite/functions.php

609 ERROR Overriding WordPress globals is prohibited

  1. onepage-lite/mts-customizer-notify/mts-customizer-notify-section.php

145 ERROR Silencing errors is forbidden

  1. onepage-lite/mts-welcome-page/class-mts-welcome-page.php

478 ERROR Silencing errors is forbidden
481 ERROR Silencing errors is forbidden

  1. Theme Sniffer has found Following error need to fix
onepage-lite/404.php
13	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

17	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

18	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

onepage-lite/archive.php
30	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'get_template_directory_uri'
40	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

41	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

46	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not 'mts_excerpt'

54	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

onepage-lite/class-tgm-plugin-activation.php
334	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.

340	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.

346	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.

352	WARNING	A gettext call containing placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.

358	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.

364	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
559	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
712	WARNING	Missing wp_unslash() before 

sanitization.
712	WARNING	Detected usage of a non-sanitized 

input variable: $_GET
770	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
1555	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
1895	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
2068	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
2139	WARNING	Missing wp_unslash() before 

sanitization.
2768	WARNING	Missing wp_unslash() before 

sanitization.
2768	WARNING	Detected usage of a non-sanitized 

input variable: $_POST
2769	WARNING	Missing wp_unslash() before 

sanitization.
2769	WARNING	Detected usage of a non-sanitized 

input variable: $_POST
2771	WARNING	Missing wp_unslash() before 

sanitization.
2771	WARNING	Detected usage of a non-sanitized 

input variable: $_POST
2916	WARNING	Missing wp_unslash() before 

sanitization.
2916	WARNING	Detected usage of a non-sanitized 

input variable: $_POST
3070	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
onepage-lite/comments.php
9	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
onepage-lite/footer.php
25	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
25	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'date'
25	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$footer_copyrights'
onepage-lite/functions/widget-recentposts.php
41	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
41	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
42	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
42	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
46	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
46	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
47	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
47	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
51	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
51	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
52	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
52	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
57	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
58	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
58	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
59	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
64	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
64	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
65	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
65	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
66	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
67	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
72	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
73	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
73	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
74	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
79	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
80	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
80	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
81	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
86	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
87	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
87	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
88	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
93	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
93	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
94	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
94	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
128	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$before_widget'
129	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$before_title'
129	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$title'
129	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$after_title'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'self'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$title_length'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$comment_num'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$date'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$show_thumb2'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$box_layout'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$show_excerpt'
130	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$excerpt_length'
131	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$after_widget'
160	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$open_li_item'
167	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'get_template_directory_uri'
167	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$thumbnail'
192	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'mts_excerpt'
197	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$close_li_item'
onepage-lite/functions/widget-social.php
170	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
170	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
170	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
170	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
172	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
172	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$this'
220	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$before_widget'
223	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$before_title'
223	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'apply_filters'
223	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$after_title'
235	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$output'
237	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$after_widget'
onepage-lite/functions.php
93	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
200	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
381	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
383	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
384	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
385	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
386	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
387	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
388	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
389	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
390	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
395	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
471	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '__'
471	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
473	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$separator'
520	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
548	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$before'
548	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$tag_links'
548	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$after'
578	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '__'
588	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'get_template_directory_uri'
609	ERROR	Overriding WordPress globals is 

prohibited
626	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
646	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
onepage-lite/header.php
26	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'get_custom_header'
62	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$twitter_url'
65	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$facebook_url'
68	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$google_plus_url'
74	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
onepage-lite/inc/template-tags.php
26	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$onepage_lite_pagination'
28	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
62	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
67	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
86	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
92	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
onepage-lite/index.php
17	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$blog_title'
20	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$blog_subtitle'
36	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'get_template_directory_uri'
47	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
48	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), 

not '_e'
53	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'mts_excerpt'
onepage-lite/mts-customizer-notify/class-mts-

customizer-notify.php
177	WARNING	Check that require_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
203	WARNING	Missing wp_unslash() before 

sanitization.
203	WARNING	Detected usage of a non-sanitized 

input variable: $_GET
205	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$action_id'
213	WARNING	Detected usage of a non-validated 

input variable: $_GET
246	WARNING	Missing wp_unslash() before 

sanitization.
246	WARNING	Detected usage of a non-sanitized 

input variable: $_GET
248	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$action_id'
254	WARNING	Detected usage of a non-validated 

input variable: $_GET
onepage-lite/mts-customizer-notify/mts-customizer-

notify-section.php
36	WARNING	Check that include_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
97	WARNING	Check that include_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
145	ERROR	Silencing errors is forbidden
onepage-lite/mts-welcome-page/class-mts-

welcome-page.php
225	WARNING	Detected usage of a non-sanitized 

input variable: $_GET
244	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$tab_key'
279	WARNING	Check that include_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
327	WARNING	Check that include_once is not 

being used to load template files. "get_template_part

()" should be used to load template files.
419	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$getting_started_item'
422	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$getting_started_item'
439	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$button_new_tab'
439	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$getting_started_item'
439	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$button_class'
439	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$getting_started_item'
478	ERROR	Silencing errors is forbidden
481	ERROR	Silencing errors is forbidden
577	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not 'mts_truncate'
652	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$child'
657	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$child'
692	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$support_step'
694	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$support_step'
699	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$support_step'
716	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), 

not '$button_new_tab'
716	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '$support_step'
716	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '$button_class'
716	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '$support_step'

740	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '$release'

743	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '$release'

903	WARNING	Missing wp_unslash() before sanitization.

903	WARNING	Detected usage of a non-sanitized input variable: $_GET

914	WARNING	Detected usage of a non-validated input variable: $_GET

914	WARNING	Missing wp_unslash() before sanitization.

914	WARNING	Detected usage of a non-sanitized 

input variable: $_GET
onepage-lite/page-home.php
18	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '__'
18	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by 

a "translators:" comment on the line above to clarify the meaning of the placeholders.
20	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not '__'
20	WARNING	A gettext call containing 

placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify 

the meaning of the placeholders.
onepage-lite/search.php
11	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
20	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not 'get_template_directory_uri'
30	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
31	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
36	WARNING	Expected next thing to be an 

escaping function (see Codex for 'Data Validation'), not 'mts_excerpt'
44	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
onepage-lite/searchform.php
3	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
4	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
onepage-lite/sidebar.php
14	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
20	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
28	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'
onepage-lite/single.php
25	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

26	WARNING	Expected next thing to be an 

escaping function (like esc_html_e() or esc_attr_e()), not '_e'

NOTE: Please read
https://make.wordpress.org/themes/handbook/review/required/ and make sure your theme follow latest guidelines.

Please address those issues and upload new version.Now I am going to close this ticket as not-approved
becuse theme has more than 5 distinct issues.

Thanks
wpcoderguy

#6 @MyThemeShop
6 years ago

Hello @wpcoderguy,
We have updated the theme here https://themes.trac.wordpress.org/ticket/52340

1. TGM Not working getting following message:
Regarding this issue, TGM is trying to install the plugin which is currently not available on the WordPress.org website. We have already submitted that plugin for review couple of weeks ago, and it is still pending for the review.

I am attaching that plugin here, please take a look http://take.ms/obMFw

2. Please remove minified version from you theme under css directory font-awesome.min
As per the guidelines here https://make.wordpress.org/themes/handbook/review/required/ : No minification of scripts or files unless you provide original files.
So we have kept minified version as it is but also added unminified version along with it in the CSS folder.

Most of the other issues are fixed except few issues which might not require a fix. Please confirm the same:

1) Data Validation
a) Expected next thing to be an escaping function

like esc_html_e() or esc_attr_e()), not ‘_e’

b) Expected next thing to be an escaping function (see Codex for ‘Data Validation’), not ‘mts_excerpt’
c) Expected next thing to be an escaping function (see Codex for ‘Data Validation’), not ‘$before_widget’

  • Only untrusted data is needed to be escaped. For static text, we can just use
    __ or _e
    
    to translate the text which is implemented properly in the theme.

The mts_excerpt function returns validated output, so there seems no need to escape the function itself while it is displayed.
Likewise, there is no need to escape the widget variables like $before_widget, $before_title, etc.


2) Check that require_once is not being used to load template files. “get_template_part()” should be used to load template files.

  • Include or require is use to include admin files like include_once( ABSPATH . ‘wp-admin/includes/plugin.php’ );

We have used get_template_part() to include separate sections of a template from independent files.


3) Detected usage of a non-sanitized input variable: $_GET

  • This error is from tgm-activation php page which uses its own sanitization function to validate data, like $this->sanitize_field($_GET[‘...’]); So this warning should also be ignored.

If anything else, please let us know.
Thank you.

Note: See TracTickets for help on using tickets.