Make WordPress Themes

Opened 3 weeks ago

Closed 3 weeks ago

#181221 closed theme (not-approved)

THEME: Comet Cat Japan_Ume – 1.4

Reported by: cometcatchip's profile cometcatchip Owned by: kafleg's profile kafleg
Priority: previously reviewed Keywords: theme-comet-cat-japan_ume
Cc: chankei613@…

Description

Comet Cat Japan_Ume - 1.1

This is a very simple theme using Tailwindcss.

Theme URL -
Author URL - http://comet-cat.com

Trac Browser - https://themes.trac.wordpress.org/browser/comet-cat-japan_ume/1.1
WordPress.org - https://wordpress.org/themes/comet-cat-japan_ume/

SVN - https://themes.svn.wordpress.org/comet-cat-japan_ume/1.1
ZIP - https://downloads.wordpress.org/theme/comet-cat-japan_ume.1.1.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [234129] https://themes.trac.wordpress.org/changeset?old_path=comet-cat-japan_ume/1.0&new_path=comet-cat-japan_ume/1.1

History:

Ticket Summary Status Resolution Owner
#161042 THEME: Comet Cat Japan_Ume – 1.0 closed not-approved kafleg
#181221 THEME: Comet Cat Japan_Ume – 1.4 closed not-approved kafleg

(this ticket)

#181545 THEME: Comet Cat Japan_Ume – 1.4.1 closed not-approved kafleg


https://themes.svn.wordpress.org/comet-cat-japan_ume/1.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • WARNING: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are comet-cat-japan_ume, twentynineteen.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "custom-logo", $args ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

Change History (5)

#1 @themetracbot
3 weeks ago

  • Summary changed from THEME: Comet Cat Japan_Ume – 1.1 to THEME: Comet Cat Japan_Ume – 1.1.2

Comet Cat Japan_Ume - 1.1.2

This is a very simple theme using Tailwindcss.

Theme URL - https://dev.comet-cat.com/wp-official-theme-develop/
Author URL - http://comet-cat.com

Trac Browser - https://themes.trac.wordpress.org/browser/comet-cat-japan_ume/1.1.2
WordPress.org - https://wordpress.org/themes/comet-cat-japan_ume/

SVN - https://themes.svn.wordpress.org/comet-cat-japan_ume/1.1.2
ZIP - https://downloads.wordpress.org/theme/comet-cat-japan_ume.1.1.2.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [234147] https://themes.trac.wordpress.org/changeset?old_path=comet-cat-japan_ume/1.1&new_path=comet-cat-japan_ume/1.1.2

History:

Ticket Summary Status Resolution Owner
#161042 THEME: Comet Cat Japan_Ume – 1.0 closed not-approved kafleg
#181221 THEME: Comet Cat Japan_Ume – 1.4 closed not-approved kafleg

(this ticket)

#181545 THEME: Comet Cat Japan_Ume – 1.4.1 closed not-approved kafleg


https://themes.svn.wordpress.org/comet-cat-japan_ume/1.1.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
  • RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.

#2 @themetracbot
3 weeks ago

  • Summary changed from THEME: Comet Cat Japan_Ume – 1.1.2 to THEME: Comet Cat Japan_Ume – 1.3

Comet Cat Japan_Ume - 1.3

This is a very simple theme using Tailwindcss.

Theme URL - https://dev.comet-cat.com/wp-official-theme-develop/
Author URL - http://comet-cat.com

Trac Browser - https://themes.trac.wordpress.org/browser/comet-cat-japan_ume/1.3
WordPress.org - https://wordpress.org/themes/comet-cat-japan_ume/

SVN - https://themes.svn.wordpress.org/comet-cat-japan_ume/1.3
ZIP - https://downloads.wordpress.org/theme/comet-cat-japan_ume.1.3.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [234148] https://themes.trac.wordpress.org/changeset?old_path=comet-cat-japan_ume/1.1.2&new_path=comet-cat-japan_ume/1.3

History:

Ticket Summary Status Resolution Owner
#161042 THEME: Comet Cat Japan_Ume – 1.0 closed not-approved kafleg
#181221 THEME: Comet Cat Japan_Ume – 1.4 closed not-approved kafleg

(this ticket)

#181545 THEME: Comet Cat Japan_Ume – 1.4.1 closed not-approved kafleg


https://themes.svn.wordpress.org/comet-cat-japan_ume/1.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
  • RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.

#3 @themetracbot
3 weeks ago

  • Summary changed from THEME: Comet Cat Japan_Ume – 1.3 to THEME: Comet Cat Japan_Ume – 1.4

Comet Cat Japan_Ume - 1.4

This is a very simple theme using Tailwindcss.

Theme URL - https://dev.comet-cat.com/wp-official-theme-develop/
Author URL - http://comet-cat.com

Trac Browser - https://themes.trac.wordpress.org/browser/comet-cat-japan_ume/1.4
WordPress.org - https://wordpress.org/themes/comet-cat-japan_ume/

SVN - https://themes.svn.wordpress.org/comet-cat-japan_ume/1.4
ZIP - https://downloads.wordpress.org/theme/comet-cat-japan_ume.1.4.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [234150] https://themes.trac.wordpress.org/changeset?old_path=comet-cat-japan_ume/1.3&new_path=comet-cat-japan_ume/1.4

History:

Ticket Summary Status Resolution Owner
#161042 THEME: Comet Cat Japan_Ume – 1.0 closed not-approved kafleg
#181221 THEME: Comet Cat Japan_Ume – 1.4 closed not-approved kafleg

(this ticket)

#181545 THEME: Comet Cat Japan_Ume – 1.4.1 closed not-approved kafleg


https://themes.svn.wordpress.org/comet-cat-japan_ume/1.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>

#4 @kafleg
3 weeks ago

  • Owner set to kafleg
  • Status changed from new to reviewing

#5 @kafleg
3 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

Use this plugin to check your theme,
https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update: https://wordpress.org/themes/upload/

Example Issues

Keyboard Navigation

  • Theme authors must provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons, and text links.
  • Some resources to help you: Information on the requirement
  • Video help for Modals, Links, Forms, Menus
  • Check TwentyTwenty using tab and shift+tab as an example
  • Check the already live theme for reference.

Theme URI and Author URI

  • Please read the Theme URI and Author URI requirements carefully.
  • Demo content in either theme URI or author URI is not allowed. Theme URI should have information about the theme and author URI should have author information.
  • Theme URI and Author URI are optional. You can remove them if they are not relevant.
  • Theme URI and Author URI are defined in style.css, you can check those links there.

Prefixing

Here’s a list of the most common things that should be prefixed:

  • PHP function names.
  • PHP class names.
  • PHP global variables.
  • Action/Filter hooks.
  • Script handles.
  • Style handles.
  • Image size names.

Read more here: https://themereview.co/prefix-all-the-things/
Example, register_menus(), enqueue_styles(), mytheme_customize_register().

Translation

  • Static/default strings must be translation ready. It is missing. example, Default Sidebar

You can always ask in the #themereview channel on WordPress slack if you have any confusion regarding the issues mentioned above.

Thank you

Note: See TracTickets for help on using tickets.