Opened 3 months ago
Closed 2 months ago
#172409 closed theme (not-approved)
THEME: healthzplus – 1.5
Reported by: | losjod | Owned by: | acosmin |
---|---|---|---|
Priority: | previously reviewed | Keywords: | theme-healthzplus |
Cc: | info@… |
Description
healthzplus - 1.5
healthzplus is a versatile WordPress theme tailored specifically for medical and healthcare professionals. Whether you run a clinic, hospital, or medical practice, healthzplus provides the tools you need to create a professional and user-friendly website.
Theme URL -
Author URL -
Trac Browser - https://themes.trac.wordpress.org/browser/healthzplus/1.5
WordPress.org - https://wordpress.org/themes/healthzplus/
SVN - https://themes.svn.wordpress.org/healthzplus/1.5
ZIP - https://downloads.wordpress.org/theme/healthzplus.1.5.zip?nostats=1
Live preview – https://playground.wordpress.net/#…
Diff with previous version: [224977] https://themes.trac.wordpress.org/changeset?old_path=healthzplus/1.4&new_path=healthzplus/1.5
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#169976 | THEME: healthzplus – 1.3 | closed | not-approved | |
#171432 | THEME: healthzplus – 1.4 | closed | not-approved | |
#172409 | THEME: healthzplus – 1.5 | closed | not-approved | |
#173957 | THEME: healthzplus – 1.8 | closed | live | |
#177411 | THEME: healthzplus – 1.9 | closed | live |
- RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
- RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
- RECOMMENDED: Could not find the comment-reply script enqueued.
- RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
- RECOMMENDED .wp-caption css class is recommended in your theme css.
- RECOMMENDED .wp-caption-text css class is recommended in your theme css.
- RECOMMENDED .gallery-caption css class is recommended in your theme css.
- RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
- RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
- RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
Change History (8)
#3
@
3 months ago
@losjod
Hi!
I have had a quick look at the theme and at this point, it does not follow the requirements.
The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.
When a ticket is closed as not approved, it loses its position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/
https://github.com/WPTRT/theme-sniffer/
Use this upload form to submit your update: https://wordpress.org/themes/upload/
- Keyboard navigation - not ok
- Some resources to help you:
- Information on the requirement
- Video help for: Modals, Links, Forms, Menus
- Check TwentyTwenty using
tab
andshift+tab
as an example
- Issues with your theme:
- the sub-menus are not accessible using the keyboard
- Some resources to help you:
- Links within content must be underlined - not ok
- Please check the content of your posts (
the_content()
), excerpts (the_excerpt()
), comments content, text widgets, custom options with large blocks of texts.
- Please check the content of your posts (
- No minification of scripts or files unless you provide original files
- custom sanitization functions (don't forget to change/add a prefix) & a few included in WP Core
- All theme text strings are to be translatable. Read the requirement
#4
@
3 months ago
4."custom sanitization functions (don't forget to change/add a prefix)";
We not found the issue you mentioned in the point 4.
We used below two files for customizer.php .
1.healthzplus\inc\customizer.php
2.healthzplus\inc\Home_Page_Customize.php
Below are sainitize_callback function in our code.
1.'sanitize_callback' => 'esc_attr'
2.'sanitize_callback' => 'healthzplus_sanitize_text',
3.'sanitize_callback' => 'wp_filter_nohtml_kses',
4.'sanitize_callback' => 'sanitize_email',
5.'sanitize_callback' => 'esc_url_raw',
Do you want to say that esc_attr, wp_filter_nohtml_kses, sanitize_email and esc_url_raw cannot use like this in sanitize_callback.?
Because except this we use healthzplus_sanitize_text which already having prefix with function name.
Please give an example so that we can understand what we missing regarding the sanitize callback function in our code.
This ticket was mentioned in Slack in #themereview by losjod. View the logs.
3 months ago
#6
@
3 months ago
@losjod esc_attr
is not a sanitization function. It should only be used to ESCAPE HTML element attributes.
The following has been generated by Theme Review Action, this is for informational purposes only.
Theme developers: the Meta team is testing a new tool to help you to discover and fix problems that might otherwise delay approval of your theme. Please give feedback on any errors and omissions in the test results here: https://github.com/WordPress/theme-review-action/issues
"healthzplus.com" found when viewing "/?p=1" (via: single.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links
"healthzplus.com" found when viewing "/" (via: front-page.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links
"healthzplus.com" found when viewing "/?cat=1" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links
"healthzplus.com" found when viewing "/?tag=alignment-2" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links
"healthzplus.com" found when viewing "/?post_format=gallery" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links