Opened 14 months ago
Closed 10 months ago
#140936 closed theme (closed-newer-version-uploaded)
THEME: Greenshift – 0.9.7
| Reported by: |
wpsoul
|
Owned by: |
acosmin
|
|---|---|---|---|
| Priority: | theme update | Keywords: | theme-greenshift full-site-editing |
| Cc: | fleeke@… |
Description
Greenshift - 0.9.7
GreenShift is theme for FSE with maximum perfomance and flexibility. The best companion theme for Greenshift plugin, page and animation builder. It has more than 12 query loop templates, a lot of predefined Post and Page layouts, support for dark mode, header and footer patterns, style switcher, library of block styles and section patterns, dark color scheme, font selector. Theme doesn’t use jquery dependencies and has conditional assets to get 100 web vitals score even without cache plugins. GreenShift can be used also to make super fast and clean Woocommerce shops. It has improved style loading for Woocommerce, better inputs, very clean design for shop pages and improved layouts for woocommerce blocks.
Theme URL - https://theme.greenshiftwp.com/
Author URL - https://greenshiftwp.com/
Trac Browser - https://themes.trac.wordpress.org/browser/greenshift/0.9.7
WordPress.org - https://wordpress.org/themes/greenshift/
SVN - https://themes.svn.wordpress.org/greenshift/0.9.7
ZIP - https://wordpress.org/themes/download/greenshift.0.9.7.zip?nostats=1
Diff with previous version: [192149] https://themes.trac.wordpress.org/changeset?old_path=greenshift/0.9.6&new_path=greenshift/0.9.7
History:
Change History (15)
#1
@
14 months ago
- Owner set to themetracbot
- Resolution set to live
- Status changed from new to closed
#3
@
14 months ago
- Owner changed from themetracbot to acosmin
- Status changed from reopened to reviewing
@wpsoul please remove the Theme Options page, you are not allowed to have such a page that saves options/data. It can only be used to describe your theme.
Do this in the following two days to avoid delisting or suspension.
My bad for assuming that you removed it, you actually said that in the review ticket.
Thank you!
#4
@
14 months ago
Please, explain me how all popular wordpress themes have Settings pages if it's not allowed
Astra has even separate panel
https://monosnap.com/file/dPEizrhhgGPFipElMztJPosuEjAJUN
GeneratePress
https://monosnap.com/file/Z5kHCUoyJwxX9LPXCHiWkxop9puHw6
Kadence
https://monosnap.com/file/ooBYyXKYaqdfOIuBBMEEFG2n8apeTl
Currently, I don't know any modern theme without options. If Block themes have no customizer, how we can add global options?
#5
@
14 months ago
@wpsoul None of the themes you mentioned saves any data to the database through those pages.
You have options for custom CSS/js... and so on.
If you want to add these types of options, you can do so in your companion plugin.
#6
@
14 months ago
All of these themes save data to database, because there are no other ways to save theme options.
All of them use Customizer with set_theme_mod which is a wrapper for update_option.
Prove
https://monosnap.com/file/fRaJTwYJFbKnuYmiSgQZMJw5ITILku
and they use update_option directly (which is better, IMHO)
https://monosnap.com/file/DujItqCis6GAhZ5X6cn4ZLlrEc1img
https://monosnap.com/file/0zzqKwi1r5rDCzrRGyJCGola3bIA5j
https://monosnap.com/file/ujb6KlDz4wBs02PMisyyjYrQbdVhsU
But Block themes have no Customizer, so we added the same function in Appearance options (this was reviewed early, previously reviewer asked us to remove a separate settings panel in Admin area, but it was ok to move it under the Appearance submenu).
Currently, I removed fields from Appearance and added options in the Site Editor.
#7
@
14 months ago
@wpsoul
Hi again,
I'm not going to argue with you on this, the theme is delisted until you remove all those options fields from the Theme Options page.
There are a few good reasons why we don't allow these types of options in the admin area, you can read more about this here -> https://make.wordpress.org/themes/2015/04/22/details-on-the-new-theme-settings-customizer-guideline/
Ping me in this ticket when you upload a new version.
Thank you!
#8
@
14 months ago
- Owner changed from acosmin to themetracbot
@wpsoul now I notice that you updated the theme, it looks ok.
Just one notice, where you use current_user_can(), it needs to use the edit_theme_options capability.
The theme is now relisted.
#10
@
14 months ago
@acosmin
The theme now has an embedded iframe youtube video in the admin at Appearance > Theme Options.
Previously this was not allowed. Are themes now allowed to do this?
There is still code in the theme that prints user added custom code directly in the header and footer including custom Javascript with no security checks.
It looks like these options have been moved from the admin to the site editor, but I cannot test it fully as it removes the core Settings and Styles icon buttons and completely breaks the site editor when clicking on the theme's added Greenshift Theme Settings button.
#11
@
14 months ago
- Resolution live deleted
- Status changed from closed to reopened
@uxl The youtube video on the about/options page is ok.
Also, could you please provide some files/lines where you see unescaped data?
@wpsoul Please fix this error that occurs while clicking on the "Greenshift Theme settings" button
ReferenceError: greenShift_params is not defined
at l (settings.js?ver=379c4c32276158ace674e842335b261a:1:378)
#12
@
14 months ago
- Owner changed from themetracbot to acosmin
- Status changed from reopened to reviewing
#13
@
14 months ago
In version 0.9.8 /inc/admin_menu/settings.php L26
echo '<style>' . wp_unslash($global_settings['custom_css']) . '</style>';
L50
echo '<style>body{' . $primary . $secondary . $tertiary . '}</style>';
L97
echo '<script>' . wp_unslash($global_settings['custom_js']) . '</script>';
Regardless of whether it is unescaped or not, this adding of custom code is plugin territory.
Core now has Custom CSS in the editor, and I don't understand why the theme has global options to change the font when this already exists in the editor.
Regarding the youtube video, I remember asking this specific question as I wanted to include a youtube instructional video just the same as this theme is now doing and was told under no circumstances would this be allowed. No embedded videos, no iframe of any kind would ever be allowed was the answers I received when I asked about this.
Theme Update for existing Live theme - automatically approved