Get WordPress

Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#2906 closed defect (bug) (fixed)

WikiFormatting link on the 'Create New Ticket' form open in new tab

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

Hello,

Can we add a target _blank to the 'WikiFormatting' link on Trac tickets.
Right now it has some js to open in a new tab but doesn't disable the standard click. Would rather it be a target _blank.

Currently, if you just click the link a new tab will open but the current page will also reload, if you have content in your ticket it will ask if you want to reload the page. Or if you cmd/ctrl click the link it will open two tabs to the resource.

Cheers

Attachments (1)

2906.patch​ (574 bytes) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (3)

@SergeyBiryukov
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Keywords has-patch added

Right now it has some js to open in a new tab but doesn't disable the standard click.

2906.patch​ adds the missing return false; to do that. We already do the same for links in ticket preview​, so this ensures consistent behaviour.

#2 @coffee2code
7 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 5696:

Trac: Ensure clicking the "WikiFormatting" link does not reload current page since the link is being opened in a new tab.

Props SergeyBiryukov.
Fixes #2906.

Note: See TracTickets for help on using tickets.