Making WordPress.org

Opened 8 years ago

Closed 7 years ago

#2369 closed defect (bug) (fixed)

Translated string doesn't fit in plugin active installs showcase (german)

Reported by: presskopp's profile Presskopp Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch has-screenshots
Cc:

Description

On https://de.wordpress.org/plugins-wp/ (german)

the translated string for the class="active-installs" does not fit the available space.

Installatione instead of Installationen

Why not push the class="tested-with" part a bit more to the right? I wonder what it's like in other languages.

Attachments (2)

2369.patch (1.6 KB) - added by SergeyBiryukov 7 years ago.
2369.png (25.9 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #meta-i18n by presskopp. View the logs.


8 years ago

#2 @dd32
8 years ago

Russian is also affected: https://ru.wordpress.org/plugins-wp/
As I said in slack:

In Russian, active installs needs about 56% minimum, and tested with needs 40%, they’re both at 48% right now.

I think we can probably get away with setting a min-width of 48% on the left most items, and leaving the right most items to either use the remaining space or wrap onto the next line instead.

#3 @Presskopp
7 years ago

I'd change

.plugin-card footer span.plugin-author{width:100%}

to

.plugin-card footer span.plugin-author, .plugin-card footer span.active-installs {
    width: 100%;
}

This ticket was mentioned in Slack in #meta by presskopp. View the logs.


7 years ago

@SergeyBiryukov
7 years ago

#5 @SergeyBiryukov
7 years ago

  • Keywords has-patch added; needs-patch removed

2369.patch implements comment:2.

@SergeyBiryukov
7 years ago

#6 @SergeyBiryukov
7 years ago

  • Keywords has-screenshots added

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


7 years ago

#8 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5857:

Plugin Directory: Account for longer translations in plugin card footer.

Fixes #2369.

Note: See TracTickets for help on using tickets.