This project is mirrored from https://git.koha-community.org/Koha-community/Koha.git.
Pull mirroring updated .
- Jul 26, 2024
-
-
To test: 1. Create a new patron. 2. Go to Tools -> Patron card creator. 3. Create a new patron card batch. 4. On the "Edit patron card batch" page, click the "Batch description:" label. 5. Observe that the corresponding <input> field is selected. Mentored-by: Catalyst Academy Signed-off-by:David Nind <david@davidnind.com> Signed-off-by:
Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' Signed-off-by:
Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by:
-
This patch fixes the fact `RANK` become a reserved word in MySQL 8.0.2 [1] To test: 1. Launch KTD with MySQL 8: $ ktd down $ DB_IMAGE=mysql:8 ktd up -d 2. Open the logs $ ktd --shell k$ tail -f /var/log/koha/kohadev/*.log 3. Create a serial, receive an issue and try to create a routing list 4. Click on `+ Add recipients` and look for Henry 5. Click `Add` and then `Close` => FAIL: Henry not added => FAIL: The logs show an error about wrong SQL syntax 6. Run: k$ prove t/db_dependent/Serials.t => FAIL: Tests explode with the same kind of error! 6. Apply this patch 7. Restart plack 8. Repeat 3 through 6 => SUCCESS: Henry added! => SUCCESS: No explosion about the SQL syntax in the logs => SUCCESS: Tests pass! 9. Sign off :-D [1] https://dev.mysql.com/doc/refman/8.0/en/keywords.html Signed-off-by:
Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by:
-
Signed-off-by:
-
Test plan: 1) Update some data in your cities table, sample for one send: "UPDATE cities SET city_state=NULL WHERE cityid=<id>" 2) Go on "/cgi-bin/koha/admin/cities.pl" and wait a entire life :) 3) Apply this patch 4) Rebuild your po files if needed 5) Reload the same page and now you get normally the datatable Sponsored by: BibLibre Signed-off-by:
Lucas Gass <lucas@bywatersolutions.com> Signed-off-by:
-
When using __() (ie. Gettext.js) we are seeing the translations that are marked as fuzzy. This is definitely not the expected behaviour. It happens because (our version of) po2json are old and no longer maintained, and just embed them. It seems that the bin we have has been upgraded to a JS version (different authors). Test plan: (replace LANG with your language code) 0. Do not apply this patch Edit misc/translator/po/LANG-messages-js.po Mark a string as fuzzy Edit ./intranet-main.tt and add the following lines inside $(document).ready console.log(_("Your string")); console.log(__("Your string")); Replace "Your string" with the string you are actually testing. Update the templates: `koha-translate --update LANG --dev kohadev && restart_all` Go to the Koha home page, open the console. => Notice that the second log in the console is displaying the fuzzy string. 1. Apply this patch Install the new version of po2json using `yarn install` Repeat the previ... -
To Test: 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled 15. APPLY PATCH 16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate. 17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests. Signed-off-by:Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by:
-
Signed-off-by:
Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by:
-
The subroutine libraries_where_can_see_things stores the list of libraries that things can be viewed from in an internal variable, so we can return this directly if we have already calculated. When returning if not cached, we dereference the list and return an array. If cached, we are returning an arrayref. This patch simply ensures we dereference the array even if already cached. Before this patch, we were fetching the patrons, then redacting all info as their branches didn't match against an arrayref, rather than checking against each branch we are allowed to view. To test: 1. Setup a library group and check the "Limit patron data access by group ." option. 2. Add some libraries to the group. ( IN k-t-d I added CPL and MPL ) 3. Create a staff account who has staff access permissions and all of the borrower permissions except "view_borrower_infos_from_any_libraries" 4. Set the home library of that staff member to one of the branch...
-
Signed-off-by:
-
Signed-off-by: -
GIVEN koha in a version later than 22.11, a list with more than ten entries WHEN the user tries to print the list THEN only the ten first results are printed EXPECTED THEN all results are printed It looks like it is an undesired effect of BZ36858. Page remains set even while printing, therefore, however the number of rows is not set, default value (10) is used. TEST PLAN 1 - create a list with more than 10 items 2 - print the list -> there is a pagination and that only 10 items are printed Apply patch 3 - print the list again -> every items are being printed Signed-off-by:
Owen Leonard <oleonard@myacpl.org> Signed-off-by:
-
In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value. Test Plan: 1) Change the Password change in OPAC field 2) Note the change doesn't take affect 3) Apply this patch 4) Change the field again 5) This time is stays! Signed-off-by:
Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by:
-
The H1 heading on the patron change password page in the staff interface is too big and should be outside of the area with form area with the white background. Test plan: 1. In the staff interface, click on top right of menu and navigate to my account. 2. Click the 'Change password' button. 3. Note that title is now outside the legend and font size is comparable to other H1 headings (e.g. Duplicate). Signed-off-by:
-
To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page." To test: 1. Apply patch 2. From the expired patron's details page see the warning and click Renew 3. Notice it renews the patron and returns to the patron details page 4. Details -> Edit -> Set the expiration date so that the patron is expired 5. Go back to your staff patron and check 'Check out and check in items' permission 6. In your expired patron's page -> Check out -> See warning -> Renew 7. Notice it renews the patron and returns to the check out page 8. Set the expired patron's expiration date so that it expires soon 9. Uncheck 'Check out and check in items' permission for your staff patron 10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details" 11. Repeat steps 2-7 and notice it returns to the correct pages Signed-off-by: -
This patch adds a check for the referrer to the circulation page. If the referrer is from the same origin's additem.pl then get the barcode from the url parameters, fill the form and submit. Test plan: 1. Apply patch 2. Enter a barcode not in the system, eg 99999 3. Click '+ Add record using fast cataloging' 4. Fill required bib fields 000, 008 and 245a and click 'Save' 5. Add required item field y - Koha item type and click 'Add item' 6. Notice the barcode is filled and the form is submitted automatically 7. Confirm the item is checked out and the dutedate specified works 8. Add an html customization somewhere else in koha with a link like http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=38&barcode=99999&duedatespec=&stickyduedate= 9. Click on the link to simulate a csrf attack 10. Confirm the checkout page is loaded for that patron but no checkout is made Signed-off-by:
Eric Garcia <cubingguy714@gmail.com> Signed-off-by:
Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by:
-
Currently we are only loading unlimited categories into the patron search, so when we return patrons from a category limited to another library we crash because we don't have the descriptions loaded. This patch removes the limit from 'categories_map' which is only used for displaying patrons. As patron visibility is a feature of permissions and groups, I don't think we should enforce if based on category limitations. NOTE: the categories for searching are still limited in the left hand filters - but not in the dropdown if you click the options button in the top search form. This is beyond the scope of this bug. To test: 1. Make sure you are logged in as Centerville 2. Do a patron search for 'Ac' -- there are two patrons: Henry (Staff) and Edna (Patron) 2. Go to Administration > Patron Categories 3. Edit the Patron (PT) category, set the Library limitations to Fairfield only 4. Do the patron search for 'Ac' again - it hangs up with a Processing box 5. Apply patch 6. Reload the page (clear cache) and confirm the results now load Signed-off-by:
Jason Robb <jrobb@sekls.org> Signed-off-by:
-
When you have an SQL report that selects cardnumber from borrowers, you get a menuitem to send the results to Batch patron modification. Currently that fails with a message about no card numbers or borrowernumbers given, because it tries to do a GET with the op show, when modborrowers.pl is expecting a POST with the op cud-show. Test plan: 1. Without the patch, Reports - Create from SQL - name it and paste select cardnumber from borrowers in the SQL textarea and save, then Run report. 2. Above the results is a "Batch operations with 20 visible records" menu, choose Batch patron modification 3. Note that instead of modifying the records, you're stuck with a message saying "No patron card numbers or borrowernumbers given." even though there's a whole string of them in the URL. 4. Apply patch, refresh the page with the results (oddly, no apparent need to even restart_all), and choose the menuitem again, but this time with a successful result. Signed-off-by:
-
- Jul 25, 2024
-
-
Tomas Cohen Arazi authored
Signed-off-by:
Tomas Cohen Arazi <tomascohen@theke.io> -
Signed-off-by:
-
To test: 1) Make sure the following tests pass: - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblios.t - db_dependent/Koha/Biblio.t Sponsored-by: Gothenburg University Library Signed-off-by:
-
On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. This patch adds line to batchMod.js which sets "checked" attribute and class "selected" to checkbox. To test: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. 4. Apply this patch. 5. Check checkbox again and refresh page. => Checkbox should be still checked. Sponsored-by: Koha-Suomi Oy Signed-off-by:
-
Martin Renvoize authored
Signed-off-by: -
Signed-off-by:
-
Signed-off-by:
-
Removal of 'bulk' column Removal of 'finetype' column Removal of 'issuelimit' column Test plan, k-t-d: 1) Add data to the relevant columns, run the following mysql: update categories set bulk = 1; update categories set finetype = 1; update categories set issuelimit = 1; 2) Run updatedatabase, notice it shows a warning and does not update the database 3) Clean up the data, run the folllowing mysql: update categories set bulk = null; update categories set finetype = null; update categories set issuelimit = null; 4) Run updatedatabase again, notice it updates the database as intended Run: t/db_dependent/Circulation/GetHardDueDate.t Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
This patch fixes various eslint errors in enhanced content JS files: - Consistent indentation - Remove variables which are declared but not used - Add missing semicolons - Add missing "var" declarations To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and enable these preferences: - OPACAmazonCoverImages - BakerTaylorEnabled - GoogleJackets - OPACLocalCoverImages - OpenLibraryCovers - Go to the OPAC and confirm that covers from these services appear correctly in search results and on detail pages. Signed-off-by:
-
This patch simply adds a conditional to ensure the biblio object has been retrieved and assumes no cover images otherwise To test: 1 - Enable system preference LocalCoverImages 2 - Perform a search in staff interface 3 - Find the biblionumebr for one of the results and delete it via the SQL backend: DELETE FROM biblio WHERE biblionumber=3; 4 - Search again. 5 - KO! Can't call method "cover_images" on an undefined value at /usr/share/koha/intranet/cgi-bin/catalogue/search.pl line 671. 6 - Reindex, confirm error is gone 7 - Apply patch 8 - Search again 9 - Delete a record from the results via SQL 10 - Reload and confirm no error 11 - Reindex and repeat search and confirm no error Signed-off-by:Julian Maurice <julian.maurice@biblibre.com> Signed-off-by:
-
Martin Renvoize authored
This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by:
Mary Blomley <mary.blomley@uwl.ac.uk> Signed-off-by:
-
To test: 1 - have a system with 2+ branches 2 - have a bib with 2+ items, all with holdingbranch=A 3 - set logged in library to A 4 - go to bib details page, confirm each item has an Edit button in the holdings table 5 - edit one item, set holdingbranch=B 6 - reload bib details page 7 - confirm the item now at branch B does not have an edit button 8 - APPLY PATCH and restart_all 9 - Try 1 - 6 again, this time you should see the proper edit buttons 10 - Set up library group: * Create a library group for library A + B * Action: Limit item editing by group 11 - Set up test user: * Create a staff patron with these permissions: * catalogue * fast_cataloguing * edit_items * view_borrower_infos_from_any_libraries * edit borrowers * Home library: library A 12 - Set up test items: * Create a record with 3 items with different home libraries: * A * B * C 13 - We expect the use to be able to edit A and B, but not C. 14 - With the same user turn OFF the view_borrower_infos_from_any_libraries permission 15 - Behavior should not change, we expect the use to be able to edit A and B, but not C. 16 - Make sure StaffDetailItemSelection still works as expected for all users. With the sys pref on the checkbox should show up for superlibrarians and users with 'tools' permissions. Signed-off-by:Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by:
Nick Clemens <nick@bywatersolutions.com> Signed-off-by:
-
Martin Renvoize authored
This patch adds a hidden op input and csrf token to the clubs hold request form. Signed-off-by:
-
- Jul 24, 2024
-
-
Martin Renvoize authored
We were having some issues with package building because we missed the update to the yarn.lock file here. Signed-off-by:
-
- Jul 23, 2024
-
-
Signed-off-by:
-
To test: 1. Make sure you have some overdue checkouts in your installation. 2. Go to Circulation > Overdues 3. Verify the ‘Checked out on’ column is visible by default, but can be hidden using the column settings 4. Verify that the export to CSV via the link on top of the table and includes the ‘Checked out on’ field. 5. Sign off and have an incredible day :D Signed-off-by:
-
Martin Renvoize authored
Signed-off-by: -
Martin Renvoize authored
Signed-off-by: -
This bug adds a new system preference 'z3950Status' which takes a yaml block and marks any items matching the conditions as unavailable via z3950 results It obeys the existing z3950 extra fields, adding item ststus to field $k To test: 0 - Apply patch, update database 1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU servers: host: localhost port 2100 database: biblios syntax: MARC21 (or UNIMARC if applicable) 2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml Also make sure to remove the backslashes escaping the hyphens 3 - Restart all 4 - Cataloging - New from Z3950 5 - Search your records, view the marc to confirm status subfield $k is included 6 - Add items to a record with various statuses (lost,damaged,withdrawn) and itemtypes 7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k 8 - Search for record above - confirm statuses show as expected 9 - Edit new syspref z3950Status - confirm the language of the pref makes sense itype: [BK] ccode: [REF] 10 - Search z39 again and confirm items and collection codes are marked 'SYSPREF' in $k 11 - Edit Authorized values - add category Z3950_STATUS 12 - Add authorized vlaue: SYSPREF with Description: System preferenced 13 - Restart all 14 - Search z39 again and confirm statuses show new description Sponsored by: Northeast Kansas Library System <https://www.nekls.org> Sponsored by: South East Kansas Library System <https://www.sekls.org > Signed-off-by:Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by:
-
