Directly pass empty or missing password parameter to WordPress #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
--admin_password
parameter is missing or an empty value is passed while executing core install commands, the password should not be generated on WP-CLI command side, rather should be passed as it is towp_install()
for WordPress to internally generate it, which in that case will also send the auto-generated password through the new blog email to the admin user.Testing
In the current tests email content is not tested. Therefore didn't attach a test for this change. Please let me know if a test is needed.
"New Blog" email before and after the change
Before the change even if password is not supplied through parameter and random password is generated, it is not send through email -
But after the change, if random password is generated then that is send through the email -