Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetpack Content Migration Flow] Enable feature flags #19759

Merged
merged 4 commits into from
Dec 9, 2022
Merged

[Jetpack Content Migration Flow] Enable feature flags #19759

merged 4 commits into from
Dec 9, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Dec 8, 2022 •
edited
Loading

Description

This PR enables the following feature flags for the Content Migration Flow project:

  • jetpackPoweredBottomSheet
  • contentMigration
  • jetpackMigrationPreventDuplicateNotifications

Testing

To test, follow the project's test plan.

Internal ref: pcdRpT-1i3-p2

Regression Notes

  1. Potential unintended areas of impact

    • N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@twstokes twstokes added this to the 21.4 milestone Dec 8, 2022
@twstokes twstokes self-assigned this Dec 8, 2022
@twstokes twstokes marked this pull request as ready for review December 8, 2022 17:42
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 8, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19759-0ac00e4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 8, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19759-0ac00e4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.
stardolly
stardolly reviewed Dec 8, 2022
View reviewed changes
Copy link

@stardolly stardolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssndon
dvdchr
dvdchr approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@twstokes
Copy link
Contributor Author

twstokes commented Dec 9, 2022 •
edited
Loading

Noting that this PR doesn't include re-enabling remote feature flag functionality for the "Disable WordPress Notifications" project - it's just the local flag.

See #19761.
@twstokes twstokes merged commit 4c217bd into trunk Dec 9, 2022
@twstokes twstokes deleted the task/enable-cmf-again branch December 9, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Content Migration Flow [Type] Task
4 participants
@twstokes @wpmobilebot @dvdchr @stardolly