Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share extension navigation bar being transparent #19700

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Fix share extension navigation bar being transparent #19700

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c4567f
Remove one redundant `#available(iOS 13, *)` check
mokagio Dec 1, 2022
4dcd17a
Add note about `UINavigationBar.appearance()` usage
mokagio Dec 1, 2022
d00af63
Set the navigation bar background color for the share extension
mokagio Dec 1, 2022
29cd627
Use `.overCurrentContext` to present both Share and Save to Draft
mokagio Dec 1, 2022
237e5db
Add entry for #19700 to `RELEASE-NOTES.txt`
mokagio Dec 1, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use .overCurrentContext to present both Share and Save to Draft 
Using `.overFullScreen` or leaving `.automatic` resulted in Share being
dismissable via swipe but that didn't restore Safari to the share menu,
leaving it instead blocked as if the presented VC was still there.

`.overCurrentContext` has no effect on the Save to Draft behavior,
leaving it the same as when using `.overFullScreen`.

On iPad, this setting result in both extensions not being full screen.
Otherwise, Share would have been full screen while Save to Draft
wouldn't.
  • Loading branch information
@mokagio
mokagio committed Dec 1, 2022
commit 29cd6274eb67a86441fdc6091a78779cd1e8db6e
6 changes: 2 additions & 4 deletions WordPress/WordPressShareExtension/MainShareViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,8 @@ private extension MainShareViewController {

let shareNavController = UINavigationController(rootViewController: editorController)

if editorController.originatingExtension == .saveToDraft {
// We need to make sure we don't end up with stacked modal view controllers by using this:
shareNavController.modalPresentationStyle = .overFullScreen
}
// We need to make sure we don't end up with stacked modal view controllers by using this:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 notice the removal of the double space between "We" and "need" 🤓
shareNavController.modalPresentationStyle = .overCurrentContext

present(shareNavController, animated: true)
}
Expand Down