Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'WordPress is better with Jetpack' bottom sheet text and button fully visible with big fonts #17503

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Nov 21, 2022

Fixes #17429

This PR fixes an issue preventing the text and button of the WordPress is better with Jetpack bottom sheet from being entirely visible on some devices with big fonts, by making the content of the bottom sheet scrollable.

To test:

Test Case 1 - Big Fonts

  1. Prerequisite: Enable the jetpack_powered_bottom_sheet_remote_field feature flag.
  2. Set max font size via Accessibility settings on device.
  3. Tap the "Jetpack Powered" badge on Me, or My SiteHome
  4. Expect to be able to scroll the content if it's not entirely visible on the screen
  5. Rotate device to landscape (make sure Auto rotate is enabled)
  6. Expect to be able to scroll the content.

Test Case 2 - Regression

  1. Restore default font size via Accessibility settings on device.
  2. Tap the "Jetpack Powered" badge on Me, or My SiteHome
  3. Expect to see the WordPress is better with Jetpack styled as before, with no visual regression
  4. Rotate device to landscape
  5. Expect to see the WordPress is better with Jetpack styled as before, with no visual regression.

Previews

Portrait

With Large Font Size
Before After
new_txl.mp4
With Default Font Size
Before After

Landscape - With Large Font Size

Before After
land_new_txl.mp4

Regression Notes

  1. Potential unintended areas of impact
    Jetpack powered bottom sheet without big fonts - on both portrait & landscape.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    N/a - UI changes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@ovitrif ovitrif added this to the 21.3 milestone Nov 21, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2022

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17503-8ff2216.apk
��� Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit8ff2216
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2022

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17503-8ff2216.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit8ff2216
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this ❤️ 👍

Feel free to merge it after taking a look at comment on landscape mode

@ovitrif
Copy link
Contributor Author

ovitrif commented Nov 22, 2022

Thanks for taking care of this ❤️ 👍

Feel free to merge it after taking a look at comment on landscape mode

Thank you for the review @ravishanker 🙇

I'll merge the PR 🚀

@ovitrif ovitrif merged commit 1d7055b into trunk Nov 22, 2022
@ovitrif ovitrif deleted the issue/17429-bottom-sheet-text-scrollable-w-big-fonts branch November 22, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants