Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/asc string mod error #2649

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix/asc string mod error #2649

wants to merge 3 commits into from

Conversation

vahidkay-meta
Copy link
Collaborator

Changes proposed in this Pull Request:

This fixes the PHP engine error that was caused by string % int operation.

Detailed test instructions:

  1. Go to Marketing > Facebook > Advertise Tab
  2. If your FB account is not connected, go to Connect tab and connect.
  3. If you don't see the error, then it means it's fixed.

Additional details:

Also removed the INSTAGRAM_STORY preview from ad preview formats. This was causing some flaky behavior.
@vahidkay-meta vahidkay-meta force-pushed the fix/asc_string_mod_error branch 3 times, most recently from e5cfb4a to 585f7a7 Compare October 17, 2023 12:34
@vahidkay-meta
Fixed the error and removed the INSTAGRAM_STORY ad preview as it was …
64bec05 
…causing issues

Fixed a bug with countries list

Fixed a bug with countries list

Fixed a bug with countries list

Fixed a bug with countries list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@vahidkay-meta