Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Run video.rAF callbacks' to rendering steps #5332

Closed
wants to merge 1 commit into from

Conversation

tguilbert-google
Copy link

@tguilbert-google tguilbert-google commented Mar 3, 2020

Adds an extra step to the 'update the rendering' portion of the event
loop processing model, which invokes the 'run the video animation frame
callbacks' algorithm, immediately before the 'run the animation frame
callbacks' algorithm.

In other words, this change describes how callbacks registered via
video.requestAnimationFrame() must be run immediately before callbacks
registered via window.requestionAnimationFrame().

The full definition of HTMLVideoElement.requestAnimationFrame() and
related terms and algorithms can be found here:
https://wicg.github.io/video-raf/

(See WHATWG Working Mode: Changes for more details.)


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 8:01 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

Parsing MDN data...
Parsing...


An unhandled exception occurred at $00000000004328AC:
EOutOfMemory: Out of memory
  $00000000004328AC
  $00000000004578A8


If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Adds an extra step to the 'update the rendering' portion of the event
loop processing model, which invokes the 'run the video animation frame
callbacks' algorithm, immediately before the 'run the animation frame
callbacks' algorithm.

In other words, this change describes how callbacks registered via
video.requestAnimationFrame() must be run immediately before callbacks
registered via window.requestionAnimationFrame().

The full definition of HTMLVideoElement.requestAnimationFrame() and
related terms and algorithms can be found here:
https://wicg.github.io/video-raf/
@tguilbert-google
Copy link
Author

  • The current official spec name is "HTMLVideoElement.requestAnimationFrame()", which is a method name. Should this be named something else, such as "Video AnimationFrameProvider Extension"?
  • In the spec reference, I used WICG. Should this be W3C instead?
@domenic
Copy link
Member

domenic commented Mar 3, 2020

Hey @tguilbert-google,

I think we should not reference the separate spec at all. This is a modification to HTMLVideoElement, and as such when that spec graduates from incubation, it should land in the HTML Standard itself, and not become a separate document.

So I would suggest morphing this pull request into something which incorporates the normative contents of https://wicg.github.io/video-raf/ into the HTML Standard, in the appropriate locations.

@tguilbert-google
Copy link
Author

Ok, thanks @domenic!

I will put a hold on doing that until there is an official position from Firefox or Safari, and the spec graduates from incubation.

Base automatically changed from master to main January 15, 2021 07:57
@tguilbert-google
Copy link
Author

tguilbert-google commented Sep 19, 2022

A small update: Safari has implemented video.requestVideoFrameCallback, and @youennf and I discussed merging the WICG/video-rvfc spec (renamed from WICG/video-raf) into the HTML standard at TPAC.

I am closing this PR and will create a new one referencing this one for context. I intend on starting this work in October. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants