Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename popover anchor positioning tests back to .tentative #43121

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 13, 2023

These use non-standard APIs, mostly the anchor attribute but
also some anchor positioning itself. As such, they should be
.tentative.

Bug: 1309178
Change-Id: Ief9c1f6375bc234b929b9301980d4be51de0b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5026613
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1223830}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@mfreed7 mfreed7 mentioned this pull request Nov 13, 2023
3 tasks
These use non-standard APIs, mostly the `anchor` attribute but
also some anchor positioning itself. As such, they should be
.tentative.

Bug: 1309178
Change-Id: Ief9c1f6375bc234b929b9301980d4be51de0b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5026613
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1223830}
@jonathan-j-lee
Copy link
Contributor

Looks like wpt-firefox-nightly-results-without-changes failed transiently with:

 0:10.07 INFO Downloading test prefs from https://hg.mozilla.org/mozilla-central/archive/tip.zip/testing/profiles/
mem avail: 14781 of 15806 MiB (93 %), swap free:    0 of    0 MiB ( 0 %)
mem avail: 14798 of 15806 MiB (93 %), swap free:    0 of    0 MiB ( 0 %)
Traceback (most recent call last):
  File "./wpt", line 10, in <module>
    wpt.main()
  File "/home/test/web-platform-tests/tools/wpt/wpt.py", line 233, in main
    rv = script(*args, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 1012, in run
    setup_cls, wptrunner_kwargs = setup_wptrunner(venv, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 984, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 249, in setup
    self.setup_kwargs(kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 321, in setup_kwargs
    prefs_root = self.browser.install_prefs(kwargs["binary"],
  File "/home/test/web-platform-tests/tools/wpt/browser.py", line 433, in install_prefs
    unzip(get(url).raw, dest=extract_dir)
  File "/home/test/web-platform-tests/tools/wpt/utils.py", line 106, in get
    resp.raise_for_status()
  File "/home/test/web-platform-tests/_venv3/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://hg.mozilla.org/mozilla-central/archive/tip.zip/testing/profiles/
[taskcluster 2023-11-13 21:02:46.151Z] === Task Finished ===
[taskcluster 2023-11-13 21:02:46.815Z] Unsuccessful task run with exit code: 1 completed in 185.284 seconds
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1932192 into master Nov 14, 2023
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5026613 branch November 14, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants