Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-anchor-position] revert-layer should only revert the Position Fallback Origin #10319

Closed
fantasai opened this issue May 13, 2024 · 3 comments

Comments

@fantasai
Copy link
Collaborator

fantasai commented May 13, 2024

The current spec defines the Position Fallback Origin with a special rule as follows:

Similar to the Animation Origin, use of the revert or revert-layer values (or anything else that would rollback the property to the preceding origin) acts as if the property was part of the Author Origin. (Thus, it instead reverts back to the User Origin.)

However the revert-layer keyword does not have this behavior. It's a special rule that applies only to the revert keyword.

It should therefore only apply to the revert keyword (and not the revert-layer keyword) when used in the Position Fallback Origin also.

@mfreed7
Copy link

mfreed7 commented May 13, 2024

Yes, this seems like an oversight in the spec. Happily, the shipped Chrome implementation follows your proposed behavior, so we should just update the spec. @tabatkins agrees and is in the process of updating the spec. Seems like no resolution is needed, but let us know if you disagree!

@frivoal
Copy link
Collaborator

frivoal commented May 15, 2024

A resolution wouldn't hurt, though I suppose this could fall under "Accepted as Obvious Bugfix" too.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-anchor-position] revert-layer should only revert the Position Fallback Origin, and agreed to the following:

  • RESOLVED: Fix definition of revert-layer's behavior to match the general behavior elsewhere
The full IRC log of that discussion <emilio> fantasai: this one is I think an oversight in the spec
<emilio> ... revert-layer is defined to revert to author origin but that's not how it works
<emilio> TabAtkins: yeah I don't think I had paid enough attention to revert-layer, will fix in the spec
<emilio> RESOLVED: Fix definition of revert-layer's behavior to match the general behavior elsewhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment