Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missed "CEPC" mentions and attribution error #288

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

wareid
Copy link
Collaborator

@wareid wareid commented May 10, 2023

Recent merges accidentally added "CEPC" back into the document, I have fixed that.

Also added the missing attribution for "patronizing" as mentioned in issue #264.


Preview | Diff

@wareid wareid requested review from TzviyaSiegman and dbooth-boston and removed request for TzviyaSiegman May 10, 2023 17:59
@wareid wareid linked an issue May 10, 2023 that may be closed by this pull request
Copy link

@dbooth-boston dbooth-boston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -760,7 +760,7 @@ <h2>
</dt>
<dd>
<p>
Language or behaviour that may appear kind or helpful but conveys a feeling of superiority or condescension.
Language or behaviour that may appear kind or helpful but conveys a feeling of superiority or condescension. <cite><a href="https://languages.oup.com/">Adapted from the Oxford Languages Dictionary.</a></cite>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame that access to the dictionary appears to be behind a paywall - the cited link is not to a dictionary but to a landing page for Oxford Languages. Not sure what change could improve that other than using a definition from a more open dictionary.

Copy link
Collaborator Author

@wareid wareid May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can access the definition by googling "patronizing", which pops up the google dictionary feature powered by Oxford. There is a direct URL but it's a bit messy, I could use it though.

I did look at other definitions from sources like Merriam-Webster and Cambridge Dictionary, but felt this one captured the meaning most clearly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a Google link may at some point in the future not resolve to Oxford Languages, since they could switch provider at any time. Hmm, tricky, I don't have a good alternative suggestion.

@wareid wareid merged commit 82dc5e2 into main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants