Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to pause emails #220

Open
1 of 3 tasks
sudar opened this issue Jun 25, 2019 · 2 comments
Open
1 of 3 tasks

Add the ability to pause emails #220

sudar opened this issue Jun 25, 2019 · 2 comments
Assignees
Labels
Next Sprint Workflow Label: Should be done by next Sprint
Milestone

Comments

@sudar
Copy link
Owner

sudar commented Jun 25, 2019

  • Add a new setting to pause/unpause emails
  • When email is paused it won't be sent, but stored in email log

TODO from #224


Attached PR(s)

@sudar sudar added the Current Sprint Workflow Label: Current in progress label Jun 25, 2019
@sudar sudar added this to the 2.3.2 milestone Jun 25, 2019
@sudar sudar modified the milestones: 2.3.2, 2.4.0 Jul 3, 2019
@sudar sudar added Next Sprint Workflow Label: Should be done by next Sprint and removed Current Sprint Workflow Label: Current in progress labels Jul 9, 2019
@sudar sudar added Current Sprint Workflow Label: Current in progress and removed Next Sprint Workflow Label: Should be done by next Sprint labels Jul 22, 2019
mariadanieldeepak pushed a commit that referenced this issue Jul 30, 2019
@mariadanieldeepak
Copy link
Collaborator

@sudar,

I see two ways to pause the emails.

1. Using phpmailer_init hook

We could use this hook and throw an error.

Cons: If there are other plugins that are monitoring for email sent status, then Email Log plugin will give false data to those plugins.

2. We could override the global $phpmailer

We can create a class that extends PHPMailer class and fake the send() method.

Cons: I don't see a Con here.

Kindly share your thoughts on which route would your prefer.

@sudar sudar added Next Sprint Workflow Label: Should be done by next Sprint and removed Current Sprint Workflow Label: Current in progress labels May 26, 2020
@sudar sudar modified the milestones: 2.4.0, 2.5.0 May 27, 2020
@sudar sudar assigned esudalaimadan and unassigned sudar Jul 6, 2020
@sudar sudar added Current Sprint Workflow Label: Current in progress and removed Next Sprint Workflow Label: Should be done by next Sprint Current Sprint Workflow Label: Current in progress labels Jul 6, 2020
@esudalaimadan
Copy link
Contributor

@sudar I have queries on requirement as well as implementation:
Queries on requirements:

  1. Are we going to pause all emails sent by WordPress or allow the user to pause selective emails?

Queries on implementation:

  1. I have gone through disable emails plugin and it is pausing all emails sent via WordPress.
  2. In stackoverflow, few people said, clear all the recipients then wp_mail won't send emails. But I think that is not the proper way to disable emails.
@esudalaimadan esudalaimadan assigned sudar and unassigned esudalaimadan Jul 22, 2020
@sudar sudar added Next Sprint Workflow Label: Should be done by next Sprint and removed Current Sprint Workflow Label: Current in progress labels Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Sprint Workflow Label: Should be done by next Sprint
3 participants