Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency of generated item to its layout never unmet #891

Closed
GeekyUX opened this issue Jul 2, 2016 · 4 comments
Closed

Dependency of generated item to its layout never unmet #891

GeekyUX opened this issue Jul 2, 2016 · 4 comments
Labels
type:bug 🐛
Milestone
4.2.2

Comments

@GeekyUX
Copy link

GeekyUX commented Jul 2, 2016 •
edited
Loading

Encountered in Nanoc 4.2.1

Steps to reproduce:

  1. Create a new site

  2. Add the preprocess rule:

    preprocess do
  items.create('', {}, '/hello.html')
end

  3. Compile; This creates output/index.html and output/hello/index.html

  4. Modify layouts/default.html in some way (I've been adding exclamation marks to <title>)

  5. Recompile

Expected outcome: Both output/index.html and output/hello/index.html should be updated.
Actual outcome: Only output/index.html is updated.
@GeekyUX
Copy link
Author

GeekyUX commented Jul 2, 2016

Note: I believe this is related to issue #885
@denisdefreyne denisdefreyne added this to the 4.2.2 milestone Jul 2, 2016
@denisdefreyne
Copy link
Member

Oh yikes—definitely a bug.
denisdefreyne added a commit that referenced this issue Jul 2, 2016
@denisdefreyne
Add spec for GH-891
ed7bc37
@denisdefreyne denisdefreyne mentioned this issue Jul 2, 2016
Merged
@denisdefreyne
Copy link
Member

Fix is in #893.
@GeekyUX
Copy link
Author

GeekyUX commented Jul 5, 2016

Thanks, Denis! That was quick! 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug 🐛
1 participant
@denisdefreyne