-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localized Microsoft Store badge / button (Fixes #14738) #14745
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14745 +/- ##
==========================================
+ Coverage 77.27% 77.29% +0.02%
==========================================
Files 160 160
Lines 8273 8281 +8
==========================================
+ Hits 6393 6401 +8
Misses 1880 1880 ☔ View full report in Codecov by Sentry. |
Thanks both for these suggestions, will follow up shortly 👍 |
6afdd73
to
a730e25
Compare
Updated helper with suggestions (thanks @robhudson!) and also optimized SVGs (thanks @janbrasna!) |
e242b3e
to
5168ed9
Compare
5168ed9
to
c72142d
Compare
c72142d
to
068ab11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! r+ 🦡
I kinda wish it was the same size and shape as the iOS and Android badges, but presumably their brand guidelines won't let us change it (and it won't appear alongside those badges anyway... unless MS brings back WinCE).
@craigcook This is how they present it (not) "side by side": |
One-line summary
Issue / Bugzilla link
#14738
Testing
Add the following code to any template to render the badge:
You can also point to Firefox Beta on the Ms Store using:
A campaign ID can be added as an optional parameter:
Finally, the installer mode can be changed (defaults to
direct
)