Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate string for console in Firefox Developer Edition features section. #14610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

turnipjs
Copy link

One-line summary

Add separate string for console in Firefox Developer Edition features section.

  • I used an AI to write some of this code.

Significant changes and points to review

Wording for console section copy.

Issue / Bugzilla link

#14609

Testing

http://localhost:8000/en-US/firefox/developer/#:~:text=Build%20and%20Perfect%20your%20sites%0Awith%20Firefox%20DevTools

Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was a human error bringing over texts from firefox-dev.tools content, thanks for noticing! The correct text should have been:

@@ -27,6 +27,7 @@ firefox-developer-inspector = Inspector
firefox-developer-inspect-and-refine = Inspect and refine code to build pixel-perfect layouts.
firefox-developer-learn-about-page-inspector = Learn more about Page Inspector
firefox-developer-console = Console
firefox-developer-logs-and-javascript = View logs and use JavaScript to interact with sites in real time.
Copy link
Contributor

@janbrasna janbrasna May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line is actually present here,

Suggested change
firefox-developer-logs-and-javascript = View logs and use JavaScript to interact with sites in real time.

right below:

  • firefox-developer-track-css
@@ -50,7 +50,7 @@ <h3 class="mzp-u-title-sm">{{ ftl('firefox-developer-build-and-perfect') }}</h3>
}
),
) %}
<p>{{ ftl('firefox-developer-inspect-and-refine') }}</p>
<p>{{ ftl('firefox-developer-logs-and-javascript') }}</p>
Copy link
Contributor

@janbrasna janbrasna May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to refer already existing string for this item:

Suggested change
<p>{{ ftl('firefox-developer-logs-and-javascript') }}</p>
<p>{{ ftl('firefox-developer-track-css') }}</p>
@alexgibson alexgibson added the Frontend HTML, CSS, JS... client side stuff label Jun 24, 2024
@alexgibson alexgibson added Frontend HTML, CSS, JS... client side stuff and removed Frontend HTML, CSS, JS... client side stuff labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff
3 participants