Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEI Evergreen page #14595

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SEI Evergreen page #14595

wants to merge 4 commits into from

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented May 23, 2024 •
edited
Loading

One-line summary

Creating the new evergreen page for SEI (Sustainability, Equality, and Inclusion) reports, which is now newly-termed as Impact reports

📆 This page is set to launch Monday July 22nd 2024

Note

We're still just waiting on the team to send us the official PDF report, which will be uploaded when ready. For now, this is good to review.

Issue / Bugzilla link

https://app.asana.com/0/home/1202716623574806/1205752499589630

Testing
@reemhamz reemhamz marked this pull request as draft May 23, 2024 04:07
@reemhamz reemhamz added the WIP 🚧 Pull request is still work in progress label May 23, 2024
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (cf619ac) to head (5b77fa1).
Report is 132 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14595      +/-   ##
==========================================
+ Coverage   76.78%   77.37%   +0.59%     
==========================================
  Files         152      161       +9     
  Lines        8124     8302     +178     
==========================================
+ Hits         6238     6424     +186     
+ Misses       1886     1878       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@reemhamz reemhamz force-pushed the sei-2024 branch 3 times, most recently from 4ddd4af to 64a9150 Compare June 11, 2024 00:48
@alexgibson alexgibson added the Frontend HTML, CSS, JS... client side stuff label Jun 24, 2024
janbrasna

This comment was marked as resolved.

Sign in to view

@reemhamz reemhamz added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour and removed WIP 🚧 Pull request is still work in progress labels Jul 11, 2024
@reemhamz reemhamz marked this pull request as ready for review July 11, 2024 04:54
janbrasna

This comment was marked as resolved.

Sign in to view

@craigcook craigcook self-assigned this Jul 16, 2024
craigcook
craigcook requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small nits (and of course still blocked on the PDF).

If we can track down the original cover image I might be able to do some Photoshop tricks to make it compress better, but if that's the best we've got then it'll have to do.
bedrock/mozorg/templates/mozorg/impact-report/index.html
) %}
<h3>Our 2024 report</h3>
<p>This holistic report by the Mozilla Corporation and Mozilla Foundation provides transparency to our employees, customers, and community on the progress of our Sustainability and Diversity, Equity, Inclusion, and Belonging commitments in 2023.</p>
<a href="" class="mzp-c-button">View the report</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for this PDF.
media/img/mozorg/impact/report-cover-high-res.jpg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image has really bad banding and compression artifacts in the sky. Is this how it was delivered? If we can get the original image maybe we can improve the quality without blowing up the file size.
media/css/products/vpn/landing.scss Show resolved Hide resolved
l10n/en/navigation_v2.ftl Outdated Show resolved Hide resolved
media/css/mozorg/impact.scss Outdated Show resolved Hide resolved
reemhamz
reemhamz commented Jul 18, 2024
View reviewed changes
bedrock/base/templates/includes/protocol/navigation/menus/whoweare.html
@@ -73,15 +73,18 @@ <h4 class="c-menu-item-title">{{ ftl('navigation-v2-mozilla-blog') }}</h4>
</a>
</section>
</li>

{% if ftl_has_messages('navigation-v2-impact', 'navigation-v2-find-out-how') %}
Copy link
Contributor Author

@reemhamz reemhamz Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this helper here as well so locales that haven't been translated for yet don't see this bit. However this Impact page is strictly in English so I don't know how critical this helper is to add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge ⚠️ Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour
4 participants
@reemhamz @craigcook @janbrasna @alexgibson