Remove archType and isARM() from site.js (Fixes #14404) #14409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P3
alexgibson
force-pushed
the
remove-arch-type-detection
branch
4 times, most recently
from
39ba637
to
9935deb
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
3 times, most recently
from
ea57bd7
to
23ca20a
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
2 times, most recently
from
55fe891
to
61bdca5
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
from
61bdca5
to
8d8b017
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
2 times, most recently
from
702fbe0
to
0f67b67
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
2 times, most recently
from
beb4082
to
c164102
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
5 times, most recently
from
5add1bc
to
391ba53
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
2 times, most recently
from
7fe6a3c
to
defbf7d
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
from
defbf7d
to
37f66b0
Compare
alexgibson
force-pushed
the
remove-arch-type-detection
branch
from
37f66b0
to
f768bee
Compare
wen-2018
approved these changes
Jul 10, 2024
linjinguang39
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
We no longer actively use this code since #14012 was completed, so we can remove these functions from site.js.
Issue / Bugzilla link
#14404
Testing
window.site.archTypeorwindow.site.isARM().