Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sa: Provide a grace period for recently unpaused identifiers #7573

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jul 4, 2024

SA method PauseIdentifiers skips identifiers unpaused within the last 2 weeks, providing a grace period for operators to fix configuration issues resulting in numerous contiguous validation failures.

Part of #7475

@beautifulentropy beautifulentropy force-pushed the grace-period-for-recently-unpaused branch from 4fcebd8 to 81db8d8 Compare July 4, 2024 15:05
@beautifulentropy beautifulentropy marked this pull request as ready for review July 4, 2024 15:10
@beautifulentropy beautifulentropy requested a review from a team as a code owner July 4, 2024 15:10
aarongable
aarongable previously approved these changes Jul 8, 2024
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

sa/sa.go Outdated Show resolved Hide resolved
@aarongable aarongable requested review from a team and jsha and removed request for a team July 8, 2024 17:56
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
jsha
jsha previously approved these changes Jul 10, 2024
@beautifulentropy beautifulentropy merged commit 15ad9fc into main Jul 11, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the grace-period-for-recently-unpaused branch July 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants