Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vParquet4: update opentelemetry-proto and add scope attrs #3649

Merged
merged 7 commits into from
May 9, 2024
Merged

vParquet4: update opentelemetry-proto and add scope attrs #3649

merged 7 commits into from
May 9, 2024

Conversation

stoewer
Copy link
Collaborator

@stoewer stoewer commented May 7, 2024 •
edited
Loading

What this PR does:

Follow up changes that were not included in the original vParquet4 PR

  • Update the opentelemetry-proto to v1.3.0
    Breaking Change The update removes the deprecated InstrumentationLibrary and InstrumentationLibrarySpan from the OTLP receivers
  • Handle attributes for instrumentation scope correctly

Which issue(s) this PR fixes:
Contribute to grafana/tempo-squad#299

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@stoewer stoewer marked this pull request as ready for review May 8, 2024 05:42
mapno
mapno reviewed May 8, 2024
View reviewed changes
Copy link
Member

@mapno mapno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update removes the deprecated instrumentation_library fields. I believe this is a breaking change for the gRPC API. It's been deprecated for over 2 years now, but I think we should still note it somewhere.
@stoewer stoewer changed the title vParquet4: update opentelemetry-proto and scope handle attrs May 9, 2024
@stoewer stoewer merged commit 3f420b6 into grafana:main May 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@stoewer @mapno