clear metrics generator wal on start up #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie-pham
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero and
stoewer
as code owners
joe-elliott
reviewed
Apr 9, 2024
modules/generator/generator.go
Outdated
| @@ -113,6 +113,9 @@ func New(cfg *Config, overrides metricsGeneratorOverrides, reg prometheus.Regist | |||
| } | |||
|
|
|||
| func (g *Generator) starting(ctx context.Context) (err error) { | |||
| // clean the wal on start up | |||
| os.RemoveAll(g.cfg.Storage.Path) | |||
There was a problem hiding this comment.
even if we don't fail on the error, we should log it if it's non-nil
joe-elliott
reviewed
Apr 10, 2024
There was a problem hiding this comment.
a simple enough change with hopefully a big impact. add a changelog please.
one other request:
i do not know the startup logic for the prom rw clients and if putting this code in starting could have a negative impact. can you verify that the prom clients are not initialized until after this line? if you have any concern you could move it to the new method.
joe-elliott
reviewed
Apr 18, 2024
joe-elliott
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Set metrics generator to clear its wal on start up.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]