Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imessagecloud support #1

Merged
merged 3 commits into from
Jun 7, 2023
Merged

imessagecloud support #1

merged 3 commits into from
Jun 7, 2023

Conversation

bradtgmurray
Copy link
Member

No description provided.

sumnerevans
sumnerevans approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using text/template makes this a lot clearer. I like it.
bridges.go
})

if err != nil {
log.Fatalf("Failed to format image for %q", bridgeType)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using %q instead of %s here?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copying from above
@bradtgmurray bradtgmurray merged commit d412b2c into main Jun 7, 2023
6 checks passed
@bradtgmurray bradtgmurray deleted the imessagecloud branch June 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@bradtgmurray @tulir @sumnerevans