[flake8-pyi] Implement PYI057

[tomasr8]

Summary

Adds Y057 from flake8-pyi.

I don't think we can apply any autofix here?

I'm new to rust so apologies in advance if I've made some rookie mistakes 😅

Test Plan

cargo test + cargo insta review

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)

python/typeshed (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/_collections_abc.pyi:10:5: PYI057 Do not use `typing.ByteString`, which has unclear semantics and is deprecated

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PYI057	1	1	0	0	0

[zanieb]

Hi! The primary reviewer for this is out right now so it might be a bit slower than usual to get reviewed.

Could you change the rule to be in Preview instead of the Stable group?

Additionally, I think use of resolve_qualified_name might be helpful in your implementation:

ruff/crates/ruff_python_semantic/src/model.rs

Lines 726 to 741 in f79c980

	/// Resolves the [`Expr`] to a fully-qualified symbol-name, if `value` resolves to an imported
	/// or builtin symbol.
	///
	/// E.g., given:
	///
	///
	/// ```python
	/// from sys import version_info as python_version
	/// print(python_version)
	/// ```
	///
	/// ...then `resolve_qualified_name(${python_version})` will resolve to `sys.version_info`.
	pub fn resolve_qualified_name<'name, 'expr: 'name>(
	&self,
	value: &'expr Expr,
	) -> Option<QualifiedName<'name>>

[zanieb]

Welcome to the project :)

[tomasr8]

Additionally, I think use of resolve_qualified_name might be helpful in your implementation:

I thought there might be something like this already, but couldn't find it. Thanks!

[AlexWaygood]

Great to see you around here @tomasr8! :-D Overall this looks great.

[tomasr8]

oops didn't notice you already fixed the conflict 😅

[AlexWaygood]

hehe, no worries

[tomasr8]

Thanks for the review! (as always :D)

I removed the fix_title implementation and used an enum instead of the full_name string as you suggested.

The bytestring_import function should also be a bit more efficient now since I check for the module id before entering the loop and return early if it doesn't match.

[AlexWaygood]

Thanks very much! Looks great now. I just pushed a couple of nitpick-fixes to your branch :-)

[AlexWaygood]

@tomasr8: I added this in my latest push. It's an optimisation we do in a lot of rules. It's a very cheap check to see whether any of the relevant modules we care about have been imported at all. If not, we can just short-circuit the rest of the rule :-)

[tomasr8]

Ah cool! I'll keep that in mind for future PRs :)