Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: unslick is missing in filterSettings #2366

Merged

Conversation

rjsdnql123
Copy link
Contributor

The unslick property is missing in the filterSettings, so the value of unslick inside InnerSlider is always undefined

…lue of unslick inside InnerSlider is always undefined
@rjsdnql123
Copy link
Contributor Author

@akiran
Upon reviewing the code for the pull request submitted earlier, I found an issue indicating a bug. Upon examining the code, I discovered that the unslick property was missing in the filterSettings function, resulting in the unslick property inside InnerSlider being undefined. I have fixed this issue.

This bug appears to manifest as the slider buttons being visible despite all elements being displayed within the slider.

before

image

  1. element 9
const settings = {
    dots: true,
    infinite: false,
    speed: 500,
    slidesToShow: 10,
    slidesToScroll: 3
  };

after

image


The problematic code only returns undefined, so the arrow will always be rendered.

image

@rjsdnql123
Copy link
Contributor Author

@akiran Without unslick, the expected behavior is not occurring. Could you please confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants