-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update event list UI: Reorder event information and display event type #152
Update event list UI: Reorder event information and display event type #152
Conversation
That seems like a good idea, they might have ideas about the labels, etc 👍🏻 @WordPress/meta-design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, but may need a few tweaks before merge.
wordpress.org/public_html/wp-content/plugins/official-wordpress-events/template-events.php
Outdated
Show resolved
Hide resolved
wordpress.org/public_html/wp-content/plugins/official-wordpress-events/template-events.php
Outdated
Show resolved
Hide resolved
wordpress.org/public_html/wp-content/plugins/official-wordpress-events/template-events.php
Outdated
Show resolved
Hide resolved
Seems like a fine micro improvement to what exists. Provided you'd be up for potentially new tweaks at some point in the future, at some point we likely need to refresh these sections holistically to the new design. So it seems fine to go with an iterative improvement for now. What do you think? |
Thanks for jumping in. It makes sense to refresh the sections holistically. Regarding a micro improvement that doesn't require too much additional time, I agree that this is good to go 👍 |
Also just to clarify, by using the term "micro improvement" I didn't mean to belittle your work 😅 — on the contrary, I appreciate the constant iteration. Thank you. |
Ah, I totally get it. Perhaps I should put it this way: "Given your feedback, I think there's no need to spend too much additional time atm, and a micro improvement would be good enough to go" Sorry for the confusion and much appreciated for the clarification 🙂 |
No confusion, all appreciation 🚀 |
@renintw I think it's worth adding the context for this PR since it's separated from its driver (WordCamp pilot event MVP). This update is being made in order to support the The Next Generation of WordCamps pilot event program. More traffic will be directed to this page and clearly communicating the event type has been identified as a needed improvement. |
Thanks. I've added it to the PR description. |
...press.org/public_html/wp-content/plugins/official-wordpress-events/official-events-online.js
Outdated
Show resolved
Hide resolved
Not fully relevant to this PR, but how is the caching supposed to work here: https://github.com/WordPress/wordpress.org/pull/152/files#diff-040d01da7ce85154ff3542bb0faaaa35dfeca9941c16446fe1701fa30fe92c26R37-R50? Am I missing something? |
I think there might be a misuse of the term here. I'm guessing it might have meant to indicate that it had loaded some cached stuff, but they actually come from the DB. Not so sure about the real intent here in the first place, though. If there are no further thoughts on this guess, I'll open a ticket later to address this minor issue. |
As per the feedback from the community, I believe it's also worth adding event type to WP Dashboard event widget. Any concerns about doing so? @StevenDufresne @naokomc |
8e8f067
to
9fe71d2
Compare
…y event type See WordPress/wordcamp.org#894 See #152 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@12668 74240141-8908-4e6f-9713-ba540dce6ec7
9fe71d2
to
18b4acd
Compare
Yeah, the database is acting as a local cache of the external APIs. It's not the canonical source, it's just a copy for performance. IMO that's a correct use of the term, but I also agree that it might be worth a comment somewhere to clarify that it's not a memory cache 👍🏻 |
Ah, I see now, thanks for clarifying. I also agree that it's worth leaving a comment to explain this is not a mem cache 👍 |
If there's room for the label, I agree it'd be good additional information for the audience. |
See WordPress/wordcamp.org#894
This PR aims to improve the event list user interface by rearranging the information for each event and displaying the event type prominently. The changes include:
This update is being made in order to support the The Next Generation of WordCamps pilot event program. More traffic will be directed to this page (
community/events
) and clearly communicating the event type has been identified as a needed improvement.Screenshots
Note
mb_convert_case
was used because even though we don't seem to translate this page into any other languages, I guess we will in the future and this function will fit the case whileucwords
won't. Also, I assumetype
in the database is specified asUTF-8
.I'm not sure if it's worth doing (or best to do) more on our current layout. Perhaps adding some labels before each piece of information, like✅Time: 2:00 p.m.
, or adding a table for it, could be beneficial? What do you all think? And Is now a good time to bring the meta design into this discussion, or someone else should be tagged instead?Testing Steps
Go to https://make.wordpress.org/community/events/ while sandboxed and check if the layout is the same as the screenshots above.