wp_video_shortcode() outputs invalid HTML #6772
Open
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp_video_shortcode() was chaging boolean attributes to 1, as of true === 1, in debug i notice it was directly happening after foreach, not by eascaping, so I have add a if statement to handle boolean attributes and directly pass our key, as Key can be directly work for boolean attributes in HTML.
Before changes:
![wp-sbc](https://cdn.statically.io/img/private-user-images.githubusercontent.com/55100775/338456481-e844342f-f391-4e2e-a158-c99ca3c9390a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzUwNTEsIm5iZiI6MTcyMjEzNDc1MSwicGF0aCI6Ii81NTEwMDc3NS8zMzg0NTY0ODEtZTg0NDM0MmYtZjM5MS00ZTJlLWExNTgtYzk5Y2EzYzkzOTBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNDU1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiOTI3NmRmZWFmNGVjNzRmZjhmNjdkYWVmYjc2Y2M2MDY0ZjgxOWMwMGQzNTdhMTA5NDIxNzVkNGRkMDgzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SBB0Ey3yI_zM_mX9r5_Lr6bWWvllTbFzUN6K9v1vWqU)
After Changes:
![wp_sac](https://cdn.statically.io/img/private-user-images.githubusercontent.com/55100775/338456549-9f897c0a-aed2-4be3-b5ae-388ab264f83c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzUwNTEsIm5iZiI6MTcyMjEzNDc1MSwicGF0aCI6Ii81NTEwMDc3NS8zMzg0NTY1NDktOWY4OTdjMGEtYWVkMi00YmUzLWI1YWUtMzg4YWIyNjRmODNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNDU1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiMzIyYzVhODM0Mjg2OTdlZjFhM2NkZWI3YmJmOGFlMTQyN2ZhZjU2NmZlNGRjM2M1NGQyYTcwYWNlZDljMjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rqK8MKkny-2pgTa9C7FjnCfT1C8ieaUcRD8yonNPh_w)
Trac Ticket: https://core.trac.wordpress.org/ticket/60178