Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WP_Term::$data dynamic property #6426

Open
wants to merge 35 commits into
base: trunk
Choose a base branch
from
Open

Fix WP_Term::$data dynamic property #6426

wants to merge 35 commits into from

Commits on Apr 26, 2024

  1. Handle the dynamic $data property in WP_Term according to the pro… 

    …posal by @hellofromtonya: https://core.trac.wordpress.org/ticket/60875.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8bce95d View commit details
    Browse the repository at this point in the history

  2. Update the docblock. 

    Use wp_trigger_error().
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1134a24 View commit details
    Browse the repository at this point in the history

  3. Update the docblock.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e40ce38 View commit details
    Browse the repository at this point in the history

  4. Update the docblock. 

    Use wp_trigger_error().
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e582409 View commit details
    Browse the repository at this point in the history

  5. Update the docblock. 

    Use wp_trigger_error().
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cf0fc29 View commit details
    Browse the repository at this point in the history

  6. Fix @return value. 

    Fix typo in the deprecated message.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    acaf7dc View commit details
    Browse the repository at this point in the history

  7. Commit WIP.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    17e4dc4 View commit details
    Browse the repository at this point in the history

  8. Implement unit test for WP_Term->data and magic methods.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b571215 View commit details
    Browse the repository at this point in the history

  9. Don't return the "data" class property in WP_Term::to_array().

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d87a4f5 View commit details
    Browse the repository at this point in the history

  10. 1. Implement new test cases for WP_Term->data. 

    2. Update docblock.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f2d11a6 View commit details
    Browse the repository at this point in the history

  11. Refactor the unit test.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ab1885a View commit details
    Browse the repository at this point in the history

  12. Add test case for the data property.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1ee82a9 View commit details
    Browse the repository at this point in the history

  13. Fix cs.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    941abd0 View commit details
    Browse the repository at this point in the history

  14. Add the object_id property.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    be9c8f5 View commit details
    Browse the repository at this point in the history

  15. Update the test.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9da3c3c View commit details
    Browse the repository at this point in the history

  16. Declaring the $data property as private since the WP_Term class is de… 

    …clared as final.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f42b14c View commit details
    Browse the repository at this point in the history

  17. Declare public properties first.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    50c176a View commit details
    Browse the repository at this point in the history

  18. Add missing class properties.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c9075af View commit details
    Browse the repository at this point in the history

  19. Add missing class properties (draft).

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e110e59 View commit details
    Browse the repository at this point in the history

  20. Don't unset the filter property.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    36467aa View commit details
    Browse the repository at this point in the history

  21. Don't access property if it's not set.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    67af5e0 View commit details
    Browse the repository at this point in the history

  22. Fix the tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6d3a183 View commit details
    Browse the repository at this point in the history

  23. Try to get rid of the $data property.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ddce8f4 View commit details
    Browse the repository at this point in the history

  24. Remove the data property and make it dynamic.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c39d689 View commit details
    Browse the repository at this point in the history

  25. Better PHPDoc blocks.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    943f5ae View commit details
    Browse the repository at this point in the history

  26. Fix the unit tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    17c7732 View commit details
    Browse the repository at this point in the history

  27. Fix the unit tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7413002 View commit details
    Browse the repository at this point in the history

  28. Don't trigger deprecated errors for public class properties.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fc39037 View commit details
    Browse the repository at this point in the history

  29. Revert test fixes.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c26880e View commit details
    Browse the repository at this point in the history

  30. Fix the failing test.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a8af5b7 View commit details
    Browse the repository at this point in the history

  31. Better method description.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d39ba8d View commit details
    Browse the repository at this point in the history

  32. Better inline comment.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fc81c00 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Better inline comment.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fa39d8f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Add more tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 1, 2024
    Configuration menu
    Copy the full SHA
    53f6374 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Change $key to $name in accordance with the signature of magic method… 

    …s in PHP.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 7, 2024
    Configuration menu
    Copy the full SHA
    74bd14f View commit details
    Browse the repository at this point in the history