Use wp_admin_notice #5142
Closed
Use wp_admin_notice #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
reviewed
Sep 6, 2023
…stead of echoing. Change needed to support theme update errors, in same commit.
costdev
reviewed
Sep 7, 2023
Mixing ternaries and concatenation is difficult to read and prone to operation order issues; assign the error message separately.
Same ternary/operator issue as in plugin-editor
joedolson
commented
Sep 14, 2023
| <?php endif; ?> | ||
| <?php | ||
| if ( is_child_theme() && $theme->get_stylesheet() === get_template() ) : | ||
| $message = ( is_writable( $file ) ) : '<strong>' . __( 'Caution:' ) . '</strong> ' ? ''; |
There was a problem hiding this comment.
Ternary operators reversed; fixed in commit.
|
Committed in r56570. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for finishing applying
wp_admin_noticefunctions across the admin. In progress.Trac ticket: https://core.trac.wordpress.org/ticket/57791
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.