The grammatical issue has been fixed in option.php #4466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @nazmulhudadev, There is one more instance https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/option.php#L730 that need to be correct.
Hi @mukeshpanchal27 Thanks for reviewing the changes and other instances. The mistake of [line 730](https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/option.php#L730) has been corrected as well.
|
Hi @mukeshpanchal27, Thanks for reviewing the changes. I've made the required changes in line 730 as well. |
mukeshpanchal27
approved these changes
May 18, 2023
krupal-panchal
approved these changes
May 19, 2023
|
@nazmulhudadev Found one more instance on https://github.com/krupal-panchal/wordpress-develop/blob/trunk/src/wp-includes/ms-blogs.php#L422 Also, address this. |
|
Hi @krupal-panchal, Thanks for spotting the typo. |
krupal-panchal
approved these changes
May 22, 2023
|
Merge the changes in #4480 into this and close that PR. |
|
committed in https://core.trac.wordpress.org/changeset/55884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mistake has been fixed.
Trac ticket: https://core.trac.wordpress.org/ticket/58338