Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh patch 51898.2.diff #3810

Closed
wants to merge 2 commits into from
Closed

Refresh patch 51898.2.diff #3810

wants to merge 2 commits into from

Conversation

bgoewert
Copy link

@bgoewert bgoewert commented Jan 1, 2023

For me, the patch did not apply against trunk. I just added the changes manually.

bgoewert@brennans-desktop:~/Projects/WordPress/wordpress-develop$ git apply ~/Downloads/51898.2.diff
error: patch failed: tools/local-env/scripts/start.js:4
error: tools/local-env/scripts/start.js: patch does not apply

Trac ticket: https://core.trac.wordpress.org/ticket/51898

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
@bgoewert @mukeshpanchal27
Update start.js to use single quote instead of backtick
9b71041 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r55473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@bgoewert @SergeyBiryukov @mukeshpanchal27