-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twenty Sixteen: reimplement frontend JS w/o jQuery #2297
base: trunk
Are you sure you want to change the base?
Conversation
Hi @sgomes! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Hi, I did a quick manual test of the PR and when there is no menu setup, I am seeing the following:
Once a menu is assigned to the primary menu location, the JS error is gone, but the keyboard navigation is not working: I can not open submenu items with the keyboard only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid to me! The main open question which would allow simplifying this code quite a bit is whether we really still need to support IE11 here, given that core has officially dropped support a while ago.
Thank you for taking a look, @carolinan and @felixarntz! The issues you mentioned should now be fixed. As for IE11, I'll wait a bit longer for a consensus before making any changes on that front. |
494dbf5
to
32e6206
Compare
Rebased on trunk. |
Reimplement Twenty Sixteen frontend JS without
jQuery
, and don't enqueue it as a result.Trac ticket: https://core.trac.wordpress.org/ticket/55126
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.