Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery in the frontend for Twenty Twelve. #1683

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Remove jQuery in the frontend for Twenty Twelve. #1683

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e262a7
Remove jQuery in the frontend for Twenty Twelve.
felixarntz Sep 16, 2021
07afc2c
Merge branch 'master' into remove/jquery-2012
felixarntz Feb 17, 2022
dfacf43
Address code review feedback, simplify JS.
felixarntz Feb 17, 2022
36962d0
Update script version.
felixarntz Feb 17, 2022
bc40e96
Merge branch 'trunk' into remove/jquery-2012
felixarntz Mar 29, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review feedback, simplify JS.
  • Loading branch information
@felixarntz
felixarntz committed Feb 17, 2022
commit dfacf4358979d8376b3bfb2aed02d4f6dfb4acbc
43 changes: 25 additions & 18 deletions src/wp-content/themes/twentytwelve/js/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
function getSiblingElements( element, selector ) {
var siblingElements = [];

Array.from( element.parentElement.children ).forEach( function( sibling ) {
element.parentElement.children.forEach( function( sibling ) {
if ( sibling !== element && ( ! selector || sibling.matches( selector ) ) ) {
siblingElements.push( sibling );
}
Expand All @@ -29,14 +29,6 @@
return siblingElements;
}

function toggleClass( element, className ) {
if ( -1 !== element.className.indexOf( className ) ) {
element.className = element.className.replace( ' ' + className, '' );
} else {
element.className += ' ' + className;
}
}

var nav = document.getElementById( 'site-navigation' ), button, menu;
if ( ! nav ) {
return;
Expand All @@ -55,35 +47,50 @@
}

button.onclick = function() {
if ( -1 === menu.className.indexOf( 'nav-menu' ) ) {
if ( ! menu.classList.contains( 'nav-menu' ) ) {
menu.className = 'nav-menu';
felixarntz marked this conversation as resolved.
Show resolved Hide resolved
}

toggleClass( button, 'toggled-on' );
toggleClass( menu, 'toggled-on' );
button.classList.toggle( 'toggled-on' );
menu.classList.toggle( 'toggled-on' );
};

// Better focus for hidden submenu items for accessibility.
function toggleParentsFocusClass() {
getParentElements( this, '.menu-item, .page_item' ).forEach( function( parentElement ) {
toggleClass( parentElement, 'focus' );
parentElement.classList.toggle( 'focus' );
} );
}
Array.from( document.querySelector( '.main-navigation' ).getElementsByTagName( 'a' ) ).forEach( function( menuLink ) {
document.querySelector( '.main-navigation' ).getElementsByTagName( 'a' ).forEach( function( menuLink ) {
menuLink.addEventListener( 'focus', toggleParentsFocusClass );
menuLink.addEventListener( 'blur', toggleParentsFocusClass );
} );

if ( 'ontouchstart' in window ) {
Array.from( document.querySelectorAll( '.menu-item-has-children > a, .page_item_has_children > a' ) ).forEach( function( menuLink ) {
document.body.addEventListener( 'touchstart', function( e ) {
for ( var target = e.target; target && target != this; target = target.parentNode ) {
if ( target.matches( '.menu-item-has-children > a, .page_item_has_children > a' ) ) {
var el = getParentElements( target, 'li' )[0];
if ( el.classList.contains( 'focus' ) ) {
e.preventDefault();
el.classList.add( 'focus' );
getSiblingElements( el, '.focus' ).forEach( function( siblingElement ) {
siblingElement.classList.remove( 'focus' );
} );
}
break;
}
}
} );
document.querySelectorAll( '.menu-item-has-children > a, .page_item_has_children > a' ).forEach( function( menuLink ) {
menuLink.addEventListener( 'touchstart', function( e ) {
var el = getParentElements( this, 'li' )[0];

if ( -1 === el.className.indexOf( 'focus' ) ) {
if ( el.classList.contains( 'focus' ) ) {
e.preventDefault();
el.className += ' focus';
el.classList.add( 'focus' );
getSiblingElements( el, '.focus' ).forEach( function( siblingElement ) {
siblingElement.className.replace( ' focus', '' );
siblingElement.classList.remove( 'focus' );
} );
}
} );
Expand Down