-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/edit posts tests #1089
Add/edit posts tests #1089
Conversation
a43d317
to
d94ab37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here. Love seeing e2e test added to Core. It's important though to not add Gutenberg e2e tests to Core because we already have a way to run Gutenberg tests in Core.
I think this one is ready for commit
I've run the tests, and they work as expected. @tellthemachines I was wondering, does it make sense to add a README to the e2e folder with information about how to run the test, how to enable headless mode for the tests for instance? Also, what does this needs to get merged? |
There's a README over here @JustinyAhin - #1451. |
@tellthemachines @talldan Is this PR ready for |
@hellofromtonya yup, this one's ready to go. It doesn't overlap with Justin's PRs as this is specific to the posts screen and Justin has been focusing on other screens so far. |
When running this test locally (via
@tellthemachines Does it pass locally for you? |
2b6c435
to
96beb3f
Compare
@hellofromtonya it passes for me! I rebased the branch in case it helps at all. |
Committed via changeset https://core.trac.wordpress.org/changeset/51990. |
Sequel to #200, fixes element targeting issues in some of the tests.
Trac ticket: https://core.trac.wordpress.org/ticket/49507
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.